diff options
| author | Jim Meyering <meyering@redhat.com> | 2010-01-24 11:31:42 +0100 |
|---|---|---|
| committer | Jim Meyering <meyering@redhat.com> | 2010-01-24 11:31:42 +0100 |
| commit | c0221df484c4a8a32e42a595b9f6caa446cc2226 (patch) | |
| tree | 4e919d4571c5ed850f1c6862ac9d3f836ff4630c /tests/test-argv-iter.c | |
| parent | 86a209c20f700b062b4ab161f586f40c94485c61 (diff) | |
| download | gnulib-c0221df484c4a8a32e42a595b9f6caa446cc2226.tar.gz | |
define STREQ(a,b) consistently, removing useless parentheses
#define STREQ(a, b) (strcmp ((a), (b)) == 0) is over-parenthesized,
since the only risk is that "a" or "b" contains an unparenthesized
comma, but if either did that, STREQ would have 3 or more arguments.
Hence, #define STREQ(a, b) (strcmp (a, b) == 0) is better.
* lib/fts.c (STREQ): Remove unnecessary parentheses.
* lib/hash-triple.c (STREQ): Likewise.
* tests/test-argv-iter.c (STREQ): Use a and b, not s1 and s2.
* lib/getugroups.c (STREQ): Likewise.
Diffstat (limited to 'tests/test-argv-iter.c')
| -rw-r--r-- | tests/test-argv-iter.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tests/test-argv-iter.c b/tests/test-argv-iter.c index 868635c56b..d0597bd5dc 100644 --- a/tests/test-argv-iter.c +++ b/tests/test-argv-iter.c @@ -26,7 +26,7 @@ #include "macros.h" #define ARRAY_CARDINALITY(Array) (sizeof (Array) / sizeof *(Array)) -#define STREQ(s1, s2) (strcmp (s1, s2) == 0) +#define STREQ(a, b) (strcmp (a, b) == 0) static FILE * write_nul_delimited_argv (char **argv) |