summaryrefslogtreecommitdiff
path: root/tests/test-strerror.c
diff options
context:
space:
mode:
authorEric Blake <eblake@redhat.com>2011-05-19 10:17:18 -0600
committerEric Blake <eblake@redhat.com>2011-05-19 10:17:18 -0600
commitd1187148b5871737463ac53328e6d20ec711afd7 (patch)
tree7c494d95c0bb894f9062db7ad45dfab022876120 /tests/test-strerror.c
parent1608fbc0104136faf98fcd89416a6c2ab4bff692 (diff)
downloadgnulib-d1187148b5871737463ac53328e6d20ec711afd7.tar.gz
strerror: relax test for Solaris
Solaris returns "Error 0" for 0 vs. "Unknown error" for -1; while that does not quite have the positive connotation that POSIX recommends, it is distinct enough that we do not need to replace the native strerror just to pick a better string. The test is really trying to reject implementations that use the same string for both 0 and 1 (modulo any %d output of the error number). * tests/test-strerror.c (main): Permit Solaris behavior. * tests/test-strerror_r.c (main): Likewise. Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'tests/test-strerror.c')
-rw-r--r--tests/test-strerror.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/tests/test-strerror.c b/tests/test-strerror.c
index 46d339e64c..03637d7850 100644
--- a/tests/test-strerror.c
+++ b/tests/test-strerror.c
@@ -51,15 +51,15 @@ main (void)
ASSERT (*str);
ASSERT (errno == 0);
- /* POSIX requires strerror (0) to succeed; use of "Unknown error" or
- "error 0" does not count as success, but "No error" works.
+ /* POSIX requires strerror (0) to succeed. Reject use of "Unknown
+ error", but allow "Success", "No error", or even Solaris' "Error
+ 0" which are distinct patterns from true out-of-range strings.
http://austingroupbugs.net/view.php?id=382 */
errno = 0;
str = strerror (0);
ASSERT (str);
ASSERT (*str);
ASSERT (errno == 0);
- ASSERT (strchr (str, '0') == NULL);
ASSERT (strstr (str, "nknown") == NULL);
/* POSIX requires strerror to produce a non-NULL result for all