diff options
author | Paul Eggert <eggert@cs.ucla.edu> | 2023-03-19 16:06:34 -0700 |
---|---|---|
committer | Paul Eggert <eggert@cs.ucla.edu> | 2023-03-19 16:07:03 -0700 |
commit | 4743071e651235e4ddafc349bd2c003043c01778 (patch) | |
tree | 7be6eeb3809153c3d60d8c966d1d8833bc49ffaa /tests | |
parent | d4e23393454bfa69a0281f9eadcd74a813f5d570 (diff) | |
download | gnulib-4743071e651235e4ddafc349bd2c003043c01778.tar.gz |
test-pselect, test-select: use different ports
I have served rare and hard-to-reproduce problems with the GNU
grep release candidate with ‘make -j5 check’ on Fedora 37 x86-64.
One possibility is that test-pselect and test-select interfere
with each other somehow when run simultaneously, as they use the
same port. Work around this possibility by using different ports
from each other, and from test-poll (which also uses 12345).
Of course it’d be better if all these tests used system-assigned
ports, but I assume that’d take more work.
* tests/test-pselect.c, tests/test-select.c (TEST_PORT): New macro.
* tests/test-select.h (TEST_PORT): Remove.
Diffstat (limited to 'tests')
-rw-r--r-- | tests/test-pselect.c | 1 | ||||
-rw-r--r-- | tests/test-select.c | 1 | ||||
-rw-r--r-- | tests/test-select.h | 2 |
3 files changed, 2 insertions, 2 deletions
diff --git a/tests/test-pselect.c b/tests/test-pselect.c index 41468684c5..a383f1d1b2 100644 --- a/tests/test-pselect.c +++ b/tests/test-pselect.c @@ -24,6 +24,7 @@ SIGNATURE_CHECK (pselect, int, (int, fd_set *restrict, fd_set *restrict, fd_set *restrict, struct timespec const *restrict, const sigset_t *restrict)); +#define TEST_PORT 12347 #include "test-select.h" static int diff --git a/tests/test-select.c b/tests/test-select.c index d04be58418..b460060351 100644 --- a/tests/test-select.c +++ b/tests/test-select.c @@ -25,6 +25,7 @@ SIGNATURE_CHECK (select, int, (int, fd_set *, fd_set *, fd_set *, struct timeval *)); +#define TEST_PORT 12346 #include "test-select.h" int diff --git a/tests/test-select.h b/tests/test-select.h index afa996f40c..ceeb485471 100644 --- a/tests/test-select.h +++ b/tests/test-select.h @@ -37,8 +37,6 @@ # include <sys/wait.h> #endif -#define TEST_PORT 12345 - typedef int (*select_fn) (int, fd_set *, fd_set *, fd_set *, struct timeval *); |