diff options
| author | Eric Blake <eblake@redhat.com> | 2013-05-10 20:24:21 -0600 |
|---|---|---|
| committer | Eric Blake <eblake@redhat.com> | 2013-05-10 20:35:20 -0600 |
| commit | a363f4ed4a0e69187c97686ac44502c49c7f4b3d (patch) | |
| tree | cde4ca54fd2195c9289c2ad47b1878bc12e44add /top | |
| parent | 97ddbcfa0bd12b45d00b74d298f6d14832981ee4 (diff) | |
| download | gnulib-a363f4ed4a0e69187c97686ac44502c49c7f4b3d.tar.gz | |
maint.mk: catch more abuse of HAVE_DECL in syntax-check
Libvirt had a patch that attempted to do:
+#elif defined(SIOCSIFLLADDR) && defined(HAVE_STRUCT_IFREQ) && \
+ defined(HAVE_DECL_LINK_ADDR)
but which was not flagged by the syntax checker as suspicious
(all HAVE_DECL_* symbols defined by autoconf are always defined
after including <config.h>, although they are sometimes defined
as the value 0). Now that code is flagged until changed to:
+#elif defined(SIOCSIFLLADDR) && defined(HAVE_STRUCT_IFREQ) && \
+ HAVE_DECL_LINK_ADDR
* top/maint.mk (sc_prohibit_defined_have_decl_tests): Relax regex.
Signed-off-by: Eric Blake <eblake@redhat.com>
Diffstat (limited to 'top')
| -rw-r--r-- | top/maint.mk | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/top/maint.mk b/top/maint.mk index 2b454a15cc..c1b786f89f 100644 --- a/top/maint.mk +++ b/top/maint.mk @@ -809,7 +809,7 @@ sc_prohibit_always_true_header_tests: $(_sc_search_regexp) sc_prohibit_defined_have_decl_tests: - @prohibit='#[ ]*if(n?def|.*\<defined)\>[ (]+HAVE_DECL_' \ + @prohibit='(#[ ]*ifn?def|\<defined)\>[ (]+HAVE_DECL_' \ halt='HAVE_DECL macros are always defined' \ $(_sc_search_regexp) |