diff options
| -rw-r--r-- | ChangeLog | 8 | ||||
| -rw-r--r-- | lib/fnmatch.c | 4 | ||||
| -rw-r--r-- | lib/getugroups.c | 4 | ||||
| -rw-r--r-- | tests/test-argv-iter.c | 2 |
4 files changed, 13 insertions, 5 deletions
@@ -1,3 +1,11 @@ +2009-07-05 Jim Meyering <meyering@redhat.com> + + remove superfluous parentheses in STREQ definition + * tests/test-argv-iter.c (STREQ): Remove redundant parentheses. + * lib/getugroups.c (STREQ): Likewise. + * lib/fnmatch.c (STREQ): Likewise. + Spotted by Bruno Haible. + 2009-07-04 Jim Meyering <meyering@redhat.com> argv-iter: new module diff --git a/lib/fnmatch.c b/lib/fnmatch.c index 48bc8b5d2a..a0356aca21 100644 --- a/lib/fnmatch.c +++ b/lib/fnmatch.c @@ -1,4 +1,4 @@ -/* Copyright (C) 1991,1992,1993,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007 +/* Copyright (C) 1991,1992,1993,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2009 Free Software Foundation, Inc. This program is free software; you can redistribute it and/or modify @@ -89,7 +89,7 @@ extern int fnmatch (const char *pattern, const char *string, int flags); # define isblank(c) ((c) == ' ' || (c) == '\t') # endif -# define STREQ(s1, s2) ((strcmp (s1, s2) == 0)) +# define STREQ(s1, s2) (strcmp (s1, s2) == 0) # if defined _LIBC || WIDE_CHAR_SUPPORT /* The GNU C library provides support for user-defined character classes diff --git a/lib/getugroups.c b/lib/getugroups.c index b266bb8c32..2207b85a17 100644 --- a/lib/getugroups.c +++ b/lib/getugroups.c @@ -1,6 +1,6 @@ /* getugroups.c -- return a list of the groups a user is in - Copyright (C) 1990, 1991, 1998-2000, 2003-2008 Free Software Foundation. + Copyright (C) 1990, 1991, 1998-2000, 2003-2009 Free Software Foundation. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -36,7 +36,7 @@ struct group *getgrent (void); #include <string.h> -#define STREQ(s1, s2) ((strcmp (s1, s2) == 0)) +#define STREQ(s1, s2) (strcmp (s1, s2) == 0) /* Like `getgroups', but for user USERNAME instead of for the current process. Store at most MAXCOUNT group IDs in the GROUPLIST array. diff --git a/tests/test-argv-iter.c b/tests/test-argv-iter.c index 7682c4a02a..5070754099 100644 --- a/tests/test-argv-iter.c +++ b/tests/test-argv-iter.c @@ -22,7 +22,7 @@ #include <string.h> #define ARRAY_CARDINALITY(Array) (sizeof (Array) / sizeof *(Array)) -#define STREQ(s1, s2) ((strcmp (s1, s2) == 0)) +#define STREQ(s1, s2) (strcmp (s1, s2) == 0) #define ASSERT(expr) \ do \ { \ |