summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog7
-rw-r--r--m4/gnulib-common.m45
2 files changed, 11 insertions, 1 deletions
diff --git a/ChangeLog b/ChangeLog
index b40542a120..55c2931e1b 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,5 +1,12 @@
2023-01-28 Bruno Haible <bruno@clisp.org>
+ Clarify _GL_ATTRIBUTE_NODISCARD code.
+ Reported by Paul Eggert.
+ * m4/gnulib-common.m4 (gl_COMMON_BODY): Add comment regarding
+ _GL_ATTRIBUTE_NODISCARD definition.
+
+2023-01-28 Bruno Haible <bruno@clisp.org>
+
unistdio/*printf: Fix negative width handling for %U, %lU, %llU.
* lib/vasnprintf.c (VASNPRINTF): In the code for %U, %lU, %llU, test for
the FLAG_LEFT bit in the flags variable.
diff --git a/m4/gnulib-common.m4 b/m4/gnulib-common.m4
index d632819864..c0181abdc5 100644
--- a/m4/gnulib-common.m4
+++ b/m4/gnulib-common.m4
@@ -381,7 +381,10 @@ AC_DEFUN([gl_COMMON_BODY], [
#ifndef _GL_ATTRIBUTE_NODISCARD
# if defined __clang__ && defined __cplusplus
/* With clang up to 15.0.6 (at least), in C++ mode, [[__nodiscard__]] produces
- a warning. */
+ a warning.
+ The 1000 below means a yet unknown threshold. When clang++ version X
+ starts supporting [[__nodiscard__]] without warning about it, you can
+ replace the 1000 with X. */
# if __clang_major__ >= 1000
# define _GL_ATTRIBUTE_NODISCARD [[__nodiscard__]]
# endif