diff options
author | Nikos Mavrogiannopoulos <nmav@gnutls.org> | 2020-03-30 08:23:03 +0200 |
---|---|---|
committer | Nikos Mavrogiannopoulos <nmav@gnutls.org> | 2020-03-30 08:23:05 +0200 |
commit | ad595778169067344bc06e327fd22a203f3b4ec5 (patch) | |
tree | 69c6cd8ac535b482cc9f7b4117b5e27449b95633 /lib/psk.c | |
parent | aba6bf96c3a1be6417fab1b35ea5e3da5f74fca3 (diff) | |
download | gnutls-ad595778169067344bc06e327fd22a203f3b4ec5.tar.gz |
psk: added checks to satisfy static analyzers
Added null checks in legacy callbacks to avoid warnings from
static analyzers. The issues do not appear to be reproducible
in real-world use.
Signed-off-by: Nikos Mavrogiannopoulos <nmav@gnutls.org>
Diffstat (limited to 'lib/psk.c')
-rw-r--r-- | lib/psk.c | 6 |
1 files changed, 6 insertions, 0 deletions
@@ -294,6 +294,9 @@ static int call_server_callback_legacy(gnutls_session_t session, gnutls_psk_server_credentials_t cred = (gnutls_psk_server_credentials_t) _gnutls_get_cred(session, GNUTLS_CRD_PSK); + if (unlikely(cred == NULL)) + return gnutls_assert_val(-1); + return cred->pwd_callback_legacy(session, (const char *) username->data, key); } @@ -367,6 +370,9 @@ static int call_client_callback_legacy(gnutls_session_t session, gnutls_psk_client_credentials_t cred = (gnutls_psk_client_credentials_t) _gnutls_get_cred(session, GNUTLS_CRD_PSK); + if (unlikely(cred == NULL)) + return gnutls_assert_val(-1); + ret = cred->get_function_legacy(session, &user_p, key); |