summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDaiki Ueno <ueno@gnu.org>2021-05-11 14:08:33 +0200
committerDaiki Ueno <ueno@gnu.org>2021-05-11 14:10:25 +0200
commit2b759674689656b300a322e6f8cea7a3acefafc6 (patch)
treeff0cbf070970f4e73913da8db2c40416b9545a8c /src
parent887622a512187d4034e18d493f02ab3cb0e38f40 (diff)
downloadgnutls-2b759674689656b300a322e6f8cea7a3acefafc6.tar.gz
psktool: tighten allocation check
Spotted by gcc analyzer: psk.c:275:21: warning: use of possibly-NULL '_username.data' where non-null expected [CWE-690] [-Wanalyzer-possible-null-argument] 275 | if (strncmp(p, (const char *) _username.data, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: Daiki Ueno <ueno@gnu.org>
Diffstat (limited to 'src')
-rw-r--r--src/psk.c6
1 files changed, 5 insertions, 1 deletions
diff --git a/src/psk.c b/src/psk.c
index 4b8a62957a..58499bd087 100644
--- a/src/psk.c
+++ b/src/psk.c
@@ -247,7 +247,11 @@ write_key(const char *username, const unsigned char *key, size_t key_size,
_username.data = (void *)new_data;
_username.size = new_size - 1;
} else {
- _username.data = (void *)strdup(username);
+ _username.data = (void *)gnutls_strdup(username);
+ if (!_username.data) {
+ ret = -1;
+ goto out;
+ }
_username.size = strlen(username);
}