summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorDaiki Ueno <ueno@gnu.org>2021-05-11 14:25:38 +0200
committerDaiki Ueno <ueno@gnu.org>2021-05-13 09:23:38 +0200
commit85be9556faafb5d7f4bc195232fb223f0a74da67 (patch)
tree669e844224e9d734a434bc88bc14c36ee423a987 /src
parent7c28cf0b943b99a573f98f280daf6e7e54ac0c15 (diff)
downloadgnutls-85be9556faafb5d7f4bc195232fb223f0a74da67.tar.gz
srptool: add missing fclose on error path
Spotted by gcc analyzer: srptool.c:113:32: warning: leak of FILE 'fp' [CWE-775] [-Wanalyzer-file-leak] 113 | return -1; | ^ also: srptool.c:560:32: warning: leak of FILE 'fp' [CWE-775] [-Wanalyzer-file-leak] 560 | return -1; | ^ Signed-off-by: Daiki Ueno <ueno@gnu.org>
Diffstat (limited to 'src')
-rw-r--r--src/srptool.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/src/srptool.c b/src/srptool.c
index 9326ac4dad..b4bc08b189 100644
--- a/src/srptool.c
+++ b/src/srptool.c
@@ -110,6 +110,7 @@ static int generate_create_conf(const char *tpasswd_conf)
g = gnutls_srp_8192_group_generator;
} else {
fprintf(stderr, "Unknown index: %d\n", index);
+ fclose(fp);
return -1;
}
@@ -585,6 +586,7 @@ crypt_int(const char *username, const char *passwd, int salt_size,
fprintf(stderr, "Cannot open '%s' for read\n",
tmpname);
(void)remove(tmpname);
+ fclose(fp);
return -1;
}