diff options
author | Shenghou Ma <minux@golang.org> | 2014-11-22 13:37:46 -0500 |
---|---|---|
committer | Shenghou Ma <minux@golang.org> | 2014-11-22 13:37:46 -0500 |
commit | f3c4b8737a5661029662c01e1dab0d38541f39ec (patch) | |
tree | 492c6d293fdb96196bba526d7784043915cd33ef | |
parent | 1b545f5fb4a07323ab2672cb437aa935086fffaf (diff) | |
download | go-f3c4b8737a5661029662c01e1dab0d38541f39ec.tar.gz |
cmd/go: fix running pprof on windows.
Fixes issue 9149.
LGTM=alex.brainman, rsc
R=rsc, dave, alex.brainman
CC=golang-codereviews
https://codereview.appspot.com/176170043
Committer: Russ Cox <rsc@golang.org>
-rw-r--r-- | src/cmd/go/tool.go | 12 |
1 files changed, 1 insertions, 11 deletions
diff --git a/src/cmd/go/tool.go b/src/cmd/go/tool.go index c96161e0f..3f11c3e3d 100644 --- a/src/cmd/go/tool.go +++ b/src/cmd/go/tool.go @@ -47,7 +47,7 @@ const toolWindowsExtension = ".exe" func tool(toolName string) string { toolPath := filepath.Join(toolDir, toolName) - if toolIsWindows && toolName != "pprof" { + if toolIsWindows { toolPath += toolWindowsExtension } // Give a nice message if there is no tool with that name. @@ -91,16 +91,6 @@ func runTool(cmd *Command, args []string) { if toolPath == "" { return } - if toolIsWindows && toolName == "pprof" { - args = append([]string{"perl", toolPath}, args[1:]...) - var err error - toolPath, err = exec.LookPath("perl") - if err != nil { - fmt.Fprintf(os.Stderr, "go tool: perl not found\n") - setExitStatus(3) - return - } - } if toolN { fmt.Printf("%s %s\n", toolPath, strings.Join(args[1:], " ")) return |