summaryrefslogtreecommitdiff
path: root/lib/codereview
diff options
context:
space:
mode:
authorShenghou Ma <minux.ma@gmail.com>2012-10-20 17:23:48 +0800
committerShenghou Ma <minux.ma@gmail.com>2012-10-20 17:23:48 +0800
commit81feb52af4c760fc2adc62bd31ba3c99b509c832 (patch)
tree026ddec3874a1040e2f7e7d60fd833199774e68d /lib/codereview
parent2597996729a085db8894a45b6c620ae22ae94a77 (diff)
downloadgo-81feb52af4c760fc2adc62bd31ba3c99b509c832.tar.gz
codereview: protect against read-only upstream repository
R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6742053
Diffstat (limited to 'lib/codereview')
-rw-r--r--lib/codereview/codereview.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 86373ccbf..ede91fdae 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1951,7 +1951,8 @@ def submit(ui, repo, *pats, **opts):
# Push changes to remote. If it works, we're committed. If not, roll back.
try:
- hg_push(ui, repo)
+ if hg_push(ui, repo):
+ raise hg_util.Abort("push error")
except hg_error.Abort, e:
if e.message.find("push creates new heads") >= 0:
# Remote repository had changes we missed.