diff options
| author | Shivakumar GN <shivakumar.gn@gmail.com> | 2012-09-27 01:50:59 +0800 |
|---|---|---|
| committer | Shivakumar GN <shivakumar.gn@gmail.com> | 2012-09-27 01:50:59 +0800 |
| commit | d21f62d96684dc93a6376fc893aa724a95ef87da (patch) | |
| tree | af67fcb1579c978678756cbe213ba9a052f7212c /lib/codereview | |
| parent | 99a7e5747e056372fe93458cd9150612efc7618c (diff) | |
| download | go-d21f62d96684dc93a6376fc893aa724a95ef87da.tar.gz | |
codereview: use subprocess.call() instead of os.spawnvp() for portability
Fixes issue 4121.
R=golang-dev, minux.ma, dave, r
CC=golang-dev
http://codereview.appspot.com/6555049
Committer: Shenghou Ma <minux.ma@gmail.com>
Diffstat (limited to 'lib/codereview')
| -rw-r--r-- | lib/codereview/codereview.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 47317ad44..62553257b 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1772,7 +1772,7 @@ def gofmt(ui, repo, *pats, **opts): cmd = ["gofmt", "-l"] if not opts["list"]: cmd += ["-w"] - if os.spawnvp(os.P_WAIT, "gofmt", cmd + files) != 0: + if subprocess.call(cmd + files) != 0: raise hg_util.Abort("gofmt did not exit cleanly") except hg_error.Abort, e: raise |