summaryrefslogtreecommitdiff
path: root/lib/codereview
diff options
context:
space:
mode:
authorHector Chu <hectorchu@gmail.com>2011-01-19 19:02:47 -0500
committerHector Chu <hectorchu@gmail.com>2011-01-19 19:02:47 -0500
commite44f4ffb617fda049beb13027d603794e10582d2 (patch)
tree809b190eab58602d9618437817159eeda9185d0e /lib/codereview
parent779d70e8bb710bf9c49ce750433893551750172f (diff)
downloadgo-e44f4ffb617fda049beb13027d603794e10582d2.tar.gz
codereview: fix hg change on Windows
hg change fails on Windows with 'No valid patches found in output from hg diff'. R=rsc CC=golang-dev http://codereview.appspot.com/4006043 Committer: Russ Cox <rsc@golang.org>
Diffstat (limited to 'lib/codereview')
-rw-r--r--lib/codereview/codereview.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 0a345d8f6..ab8415e08 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -2607,7 +2607,7 @@ class MercurialVCS(VersionControlSystem):
self.base_rev = self.options.revision
else:
mqparent, err = RunShellWithReturnCode(['hg', 'log', '--rev', 'qparent', '--template={node}'])
- if not err:
+ if not err and mqparent != "":
self.base_rev = mqparent
else:
self.base_rev = RunShell(["hg", "parents", "-q"]).split(':')[1].strip()