summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2014-06-05 16:40:09 -0400
committerRuss Cox <rsc@golang.org>2014-06-05 16:40:09 -0400
commit5e37eea1de83ea17e43cf601ba55dc47afb177b8 (patch)
treec4af66265f3732e3647af531c4e5a33d578e4cf5 /lib
parentfa055adf81fea4e70d39535f1298424482790fb6 (diff)
downloadgo-5e37eea1de83ea17e43cf601ba55dc47afb177b8.tar.gz
codereview: do not add defaultcc for private CLs
LGTM=r R=r, 0xjnml, bradfitz, iant CC=golang-codereviews https://codereview.appspot.com/103070046
Diffstat (limited to 'lib')
-rw-r--r--lib/codereview/codereview.py4
1 files changed, 2 insertions, 2 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 67341ebc3..936e0b685 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -846,7 +846,7 @@ def CommandLineCL(ui, repo, pats, opts, op="verb", defaultcc=None):
cl.reviewer = Add(cl.reviewer, SplitCommaSpace(opts.get('reviewer')))
if opts.get('cc'):
cl.cc = Add(cl.cc, SplitCommaSpace(opts.get('cc')))
- if defaultcc:
+ if defaultcc and not cl.private:
cl.cc = Add(cl.cc, defaultcc)
if cl.name == "new":
if opts.get('message'):
@@ -1845,7 +1845,7 @@ def mail(ui, repo, *pats, **opts):
# This makes sure that it appears in the
# codereview.appspot.com/user/defaultcc
# page, so that it doesn't get dropped on the floor.
- if not defaultcc:
+ if not defaultcc or cl.private:
raise hg_util.Abort("no reviewers listed in CL")
cl.cc = Sub(cl.cc, defaultcc)
cl.reviewer = defaultcc