diff options
| author | Brad Fitzpatrick <bradfitz@golang.org> | 2011-05-23 14:27:51 -0700 |
|---|---|---|
| committer | Brad Fitzpatrick <bradfitz@golang.org> | 2011-05-23 14:27:51 -0700 |
| commit | fe604a6a33cf244947aed3f7a4aafa8a0b072ef6 (patch) | |
| tree | ff1b9c361c0aa30d9b365887cf889e0d29479b23 /misc/chrome | |
| parent | f77a87d86283fe966d6d815b70244b4f8b59d8c7 (diff) | |
| download | go-fe604a6a33cf244947aed3f7a4aafa8a0b072ef6.tar.gz | |
gophertool: also accept commit form 8486:ab29d2698a47
... as "hg log" produces by default.
And add a README.
R=rsc, bradfitz
CC=golang-dev
http://codereview.appspot.com/4529080
Diffstat (limited to 'misc/chrome')
| -rw-r--r-- | misc/chrome/gophertool/README.txt | 8 | ||||
| -rw-r--r-- | misc/chrome/gophertool/popup.html | 7 |
2 files changed, 12 insertions, 3 deletions
diff --git a/misc/chrome/gophertool/README.txt b/misc/chrome/gophertool/README.txt new file mode 100644 index 000000000..a7c0b4b26 --- /dev/null +++ b/misc/chrome/gophertool/README.txt @@ -0,0 +1,8 @@ +To install: + +1) chrome://extensions/ +2) click "[+] Developer Mode" in top right +3) "Load unpacked extension..." +4) pick $GOROOT/misc/chrome/gophertool + +Done. It'll now auto-reload from source. diff --git a/misc/chrome/gophertool/popup.html b/misc/chrome/gophertool/popup.html index a953054c7..4e30ced86 100644 --- a/misc/chrome/gophertool/popup.html +++ b/misc/chrome/gophertool/popup.html @@ -13,7 +13,7 @@ function focusinput() { } var numericRE = /^\d+$/; -var commitRE = /^[0-9a-f]{6,20}$/; +var commitRE = /^(?:\d+:)?([0-9a-f]{6,20})$/; // e.g "8486:ab29d2698a47" or "ab29d2698a47" var pkgRE = /^[a-z0-9_\/]+$/; function navigate() { @@ -38,8 +38,9 @@ function navigate() { return success("http://codereview.appspot.com/" + t + "/"); } - if (commitRE.test(t)) { - return success("http://code.google.com/p/go/source/detail?r=" + t); + var match = commitRE.exec(t); + if (match) { + return success("http://code.google.com/p/go/source/detail?r=" + match[1]) } if (pkgRE.test(t)) { |