diff options
| author | Tyler Bunnell <tylerbunnell@gmail.com> | 2013-03-07 19:06:19 +0900 |
|---|---|---|
| committer | Tyler Bunnell <tylerbunnell@gmail.com> | 2013-03-07 19:06:19 +0900 |
| commit | eeadc61bba2ad4665524123dd0b2a53f4cb14d26 (patch) | |
| tree | b85904058730abe4ab6020a3fb9529751c77684e /src/cmd/fix | |
| parent | dde1b80efd267e66758d71c3e4dfedc44d596d9d (diff) | |
| download | go-eeadc61bba2ad4665524123dd0b2a53f4cb14d26.tar.gz | |
cmd/fix: remove redundant 0 port
Fixes issue 4505.
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://codereview.appspot.com/7468043
Committer: Mikio Hara <mikioh.mikioh@gmail.com>
Diffstat (limited to 'src/cmd/fix')
| -rw-r--r-- | src/cmd/fix/netipv6zone.go | 11 | ||||
| -rw-r--r-- | src/cmd/fix/netipv6zone_test.go | 6 |
2 files changed, 12 insertions, 5 deletions
diff --git a/src/cmd/fix/netipv6zone.go b/src/cmd/fix/netipv6zone.go index 587b9ffec..bbaf5fc08 100644 --- a/src/cmd/fix/netipv6zone.go +++ b/src/cmd/fix/netipv6zone.go @@ -57,10 +57,15 @@ func netipv6zone(f *ast.File) bool { Value: e, } } else { - cl.Elts[i] = &ast.KeyValueExpr{ - Key: ast.NewIdent("Port"), - Value: e, + if e.(*ast.BasicLit).Value == "0" { + cl.Elts = append(cl.Elts[:i], cl.Elts[i+1:]...) + } else { + cl.Elts[i] = &ast.KeyValueExpr{ + Key: ast.NewIdent("Port"), + Value: e, + } } + } } fixed = true diff --git a/src/cmd/fix/netipv6zone_test.go b/src/cmd/fix/netipv6zone_test.go index 229daa386..569363e1f 100644 --- a/src/cmd/fix/netipv6zone_test.go +++ b/src/cmd/fix/netipv6zone_test.go @@ -26,7 +26,8 @@ func f() net.Addr { c := &net.IPAddr{ip1} sub(&net.UDPAddr{ip2, 12345}) d := &net.TCPAddr{IP: ip3, Port: 54321} - return &net.TCPAddr{ip4}, nil + e := &net.TCPAddr{ip4, 0} + return &net.TCPAddr{ip5}, nil } `, Out: `package main @@ -44,7 +45,8 @@ func f() net.Addr { c := &net.IPAddr{IP: ip1} sub(&net.UDPAddr{IP: ip2, Port: 12345}) d := &net.TCPAddr{IP: ip3, Port: 54321} - return &net.TCPAddr{IP: ip4}, nil + e := &net.TCPAddr{IP: ip4} + return &net.TCPAddr{IP: ip5}, nil } `, }, |