diff options
| author | Austin Clements <austin@google.com> | 2014-11-04 09:43:37 -0500 |
|---|---|---|
| committer | Austin Clements <austin@google.com> | 2014-11-04 09:43:37 -0500 |
| commit | 44ac5f9624eb5d83e576cdcebf6e8f542bebaf37 (patch) | |
| tree | 784b3b7dafd2c23aed90239e30bf13be436d63d1 /src/cmd | |
| parent | 3ad646b1c04ba64796abf1aab9f9af1bee6e6719 (diff) | |
| download | go-44ac5f9624eb5d83e576cdcebf6e8f542bebaf37.tar.gz | |
gc: abort if given an unknown debug (-d) flag
The check for unknown command line debug flags in gc was
incorrect: the loop over debugtab terminates when it reaches a
nil entry, but it was only reporting an error if the parser
had passed the last entry of debugtab (which it never did).
Fix this by reporting the usage error if the loop reaches a
nil entry.
LGTM=rsc
R=rsc
CC=golang-codereviews
https://codereview.appspot.com/166110043
Diffstat (limited to 'src/cmd')
| -rw-r--r-- | src/cmd/gc/lex.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/cmd/gc/lex.c b/src/cmd/gc/lex.c index 2303b442c..523ba37aa 100644 --- a/src/cmd/gc/lex.c +++ b/src/cmd/gc/lex.c @@ -344,8 +344,8 @@ main(int argc, char *argv[]) break; } } - if(j == nelem(debugtab)) - fatal("unknown debug information -d '%s'\n", f[i]); + if(debugtab[j].name == nil) + sysfatal("unknown debug information -d '%s'\n", f[i]); } } |