diff options
author | Russ Cox <rsc@golang.org> | 2014-08-27 11:32:17 -0400 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2014-08-27 11:32:17 -0400 |
commit | 4f558e93026d8de1761b9adc74b4a8b9b0e695a8 (patch) | |
tree | 3fecfb0c28de9554cf04dd7048798f3e1556dd3f /src/pkg/sync | |
parent | 774e69a52e8e4af445a3f259c3a888fc3a66776b (diff) | |
download | go-4f558e93026d8de1761b9adc74b4a8b9b0e695a8.tar.gz |
cmd/cc, runtime: convert C compilers to use Go calling convention
To date, the C compilers and Go compilers differed only in how
values were returned from functions. This made it difficult to call
Go from C or C from Go if return values were involved. It also made
assembly called from Go and assembly called from C different.
This CL changes the C compiler to use the Go conventions, passing
results on the stack, after the arguments.
[Exception: this does not apply to C ... functions, because you can't
know where on the stack the arguments end.]
By doing this, the CL makes it possible to rewrite C functions into Go
one at a time, without worrying about which languages call that
function or which languages it calls.
This CL also updates all the assembly files in package runtime to use
the new conventions. Argument references of the form 40(SP) have
been rewritten to the form name+10(FP) instead, and there are now
Go func prototypes for every assembly function called from C or Go.
This means that 'go vet runtime' checks effectively every assembly
function, and go vet's output was used to automate the bulk of the
conversion.
Some functions, like seek and nsec on Plan 9, needed to be rewritten.
Many assembly routines called from C were reading arguments
incorrectly, using MOVL instead of MOVQ or vice versa, especially on
the less used systems like openbsd.
These were found by go vet and have been corrected too.
If we're lucky, this may reduce flakiness on those systems.
Tested on:
darwin/386
darwin/amd64
linux/arm
linux/386
linux/amd64
If this breaks another system, the bug is almost certainly in the
sys_$GOOS_$GOARCH.s file, since the rest of the CL is tested
by the combination of the above systems.
LGTM=dvyukov, iant
R=golang-codereviews, 0intro, dave, alex.brainman, dvyukov, iant
CC=golang-codereviews, josharian, r
https://codereview.appspot.com/135830043
Diffstat (limited to 'src/pkg/sync')
-rw-r--r-- | src/pkg/sync/atomic/asm_linux_arm.s | 24 |
1 files changed, 2 insertions, 22 deletions
diff --git a/src/pkg/sync/atomic/asm_linux_arm.s b/src/pkg/sync/atomic/asm_linux_arm.s index bfcfd7977..63f1f9e38 100644 --- a/src/pkg/sync/atomic/asm_linux_arm.s +++ b/src/pkg/sync/atomic/asm_linux_arm.s @@ -121,28 +121,8 @@ TEXT kernelCAS64<>(SB),NOSPLIT,$0-21 MOVW R0, 20(FP) RET -TEXT ·generalCAS64(SB),NOSPLIT,$20-21 - // bool runtime·cas64(uint64 volatile *addr, uint64 old, uint64 new) - MOVW addr+0(FP), R0 - // trigger potential paging fault here, - // because a fault in runtime.cas64 will hang. - MOVW (R0), R2 - // make unaligned atomic access panic - AND.S $7, R0, R1 - BEQ 2(PC) - MOVW R1, (R1) - MOVW R0, 4(R13) - MOVW old_lo+4(FP), R1 - MOVW R1, 8(R13) - MOVW old_hi+8(FP), R1 - MOVW R1, 12(R13) - MOVW new_lo+12(FP), R2 - MOVW R2, 16(R13) - MOVW new_hi+16(FP), R3 - MOVW R3, 20(R13) - BL runtime·cas64(SB) - MOVB R0, ret+20(FP) - RET +TEXT ·generalCAS64(SB),NOSPLIT,$0-21 + B runtime·cas64(SB) GLOBL armCAS64(SB), $4 |