diff options
| author | Russ Cox <rsc@golang.org> | 2014-09-04 00:54:37 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-09-04 00:54:37 -0400 |
| commit | 905ce7116ce5f5005d7f8cb6ce3697f5592a46d7 (patch) | |
| tree | 91b80b4cb012e98eedc4ed6700e04aa747ba0994 /src/pkg | |
| parent | 372300dd9891f1ecaf10aeea9691329227ada0b6 (diff) | |
| download | go-905ce7116ce5f5005d7f8cb6ce3697f5592a46d7.tar.gz | |
runtime: fix sigtrampPC on Windows
The arm5 build breakage at CL 139110043 was caused by
calling funcPC on a lessstack defined as a struct{}.
That symbol ended up with a non-4-aligned address,
which caused the memory fault that broke the builders.
The definition of lessstack was fixed in CL 140880043.
Tracking that down suggested that it would be worth
looking for the same bug elsewhere in the directory.
This is the only one I found.
LGTM=bradfitz
R=golang-codereviews, dave, bradfitz
CC=dvyukov, golang-codereviews, iant, khr, r
https://codereview.appspot.com/134410043
Diffstat (limited to 'src/pkg')
| -rw-r--r-- | src/pkg/runtime/traceback_windows.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/pkg/runtime/traceback_windows.go b/src/pkg/runtime/traceback_windows.go index 892bed04c..89dc1336e 100644 --- a/src/pkg/runtime/traceback_windows.go +++ b/src/pkg/runtime/traceback_windows.go @@ -10,7 +10,7 @@ import "unsafe" // The traceback needs to recognize it on link register architectures. var sigtrampPC uintptr -var sigtramp struct{} // assembly function +func sigtramp() func init() { sigtrampPC = funcPC(sigtramp) |