diff options
| author | Russ Cox <rsc@golang.org> | 2014-09-12 00:23:03 -0400 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2014-09-12 00:23:03 -0400 |
| commit | 9ea7b4e606b033d7c12c67fa2508f74aca2a8118 (patch) | |
| tree | 9cb1117a680c35620ee11e003c070449beb086bc /src/syscall/asm_linux_arm.s | |
| parent | 01cc50951b57fd695075fa8a7e53025cf6115da0 (diff) | |
| download | go-9ea7b4e606b033d7c12c67fa2508f74aca2a8118.tar.gz | |
syscall: make func Syscall use pointer maps from Go prototypes
Before, Syscall and friends were having their arguments
treated conservatively. Now they will use the Go prototype,
which will mean the arguments are not considered pointers
at all.
This is safe because of CL 139360044.
The fact that all these non-Solaris systems were using
conservative scanning of the Syscall arguments is why
the failure that prompted CL 139360044 was only
observed on Solaris, which does something completely different.
If we'd done this earlier, we'd have seen the Solaris
failure in more places.
LGTM=khr
R=khr
CC=golang-codereviews
https://codereview.appspot.com/144730043
Diffstat (limited to 'src/syscall/asm_linux_arm.s')
| -rw-r--r-- | src/syscall/asm_linux_arm.s | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/syscall/asm_linux_arm.s b/src/syscall/asm_linux_arm.s index 3be0a13e1..edb5b21a7 100644 --- a/src/syscall/asm_linux_arm.s +++ b/src/syscall/asm_linux_arm.s @@ -13,6 +13,7 @@ // func Syscall(syscall uintptr, a1, a2, a3 uintptr) (r1, r2, err uintptr); TEXT ·Syscall(SB),NOSPLIT,$0-28 + GO_ARGS BL runtime·entersyscall(SB) MOVW 4(SP), R7 MOVW 8(SP), R0 @@ -44,6 +45,7 @@ ok: // func Syscall6(trap uintptr, a1, a2, a3, a4, a5, a6 uintptr) (r1, r2, err uintptr); // Actually Syscall5 but the rest of the code expects it to be named Syscall6. TEXT ·Syscall6(SB),NOSPLIT,$0-40 + GO_ARGS BL runtime·entersyscall(SB) MOVW 4(SP), R7 // syscall entry MOVW 8(SP), R0 @@ -75,6 +77,7 @@ ok6: // func RawSyscall6(trap uintptr, a1, a2, a3, a4, a5, a6 uintptr) (r1, r2, err uintptr); // Actually RawSyscall5 but the rest of the code expects it to be named RawSyscall6. TEXT ·RawSyscall6(SB),NOSPLIT,$0-40 + GO_ARGS MOVW 4(SP), R7 // syscall entry MOVW 8(SP), R0 MOVW 12(SP), R1 @@ -134,6 +137,7 @@ okseek: // func RawSyscall(trap uintptr, a1, a2, a3 uintptr) (r1, r2, err uintptr); TEXT ·RawSyscall(SB),NOSPLIT,$0-28 + GO_ARGS MOVW 4(SP), R7 // syscall entry MOVW 8(SP), R0 MOVW 12(SP), R1 |