diff options
author | R?my Oudompheng <oudomphe@phare.normalesup.org> | 2014-02-27 08:07:50 +0100 |
---|---|---|
committer | R?my Oudompheng <oudomphe@phare.normalesup.org> | 2014-02-27 08:07:50 +0100 |
commit | de8e2daa0a072ae637e418c231e4fc26b5031e4a (patch) | |
tree | 69c2cbf079d875951d1ac850260eea3d9aa3b277 /test/cmp.go | |
parent | 5f5d288fe5d5c1e87d67a87e89b1eb4aca2c71c0 (diff) | |
download | go-de8e2daa0a072ae637e418c231e4fc26b5031e4a.tar.gz |
cmd/gc: do not nop-convert equivalent but different interface types.
The cached computed interface tables are indexed by the interface
types, not by the unnamed underlying interfaces
To preserve the invariants expected by interface comparison, an
itab generated for an interface type must not be used for a value
of a different interface type even if the representation is identical.
Fixes issue 7207.
LGTM=rsc
R=rsc, iant, khr
CC=golang-codereviews
https://codereview.appspot.com/69210044
Diffstat (limited to 'test/cmp.go')
-rw-r--r-- | test/cmp.go | 42 |
1 files changed, 42 insertions, 0 deletions
diff --git a/test/cmp.go b/test/cmp.go index 9ac0ebe79..80d1bf699 100644 --- a/test/cmp.go +++ b/test/cmp.go @@ -35,6 +35,10 @@ func istrue(b bool) { type T *int +type X int + +func (X) x() {} + func main() { var a []int var b map[string]int @@ -129,6 +133,44 @@ func main() { panic("bad m[c]") } + // interface comparisons (issue 7207) + { + type I1 interface { + x() + } + type I2 interface { + x() + } + a1 := I1(X(0)) + b1 := I1(X(1)) + a2 := I2(X(0)) + b2 := I2(X(1)) + a3 := I1(a2) + a4 := I2(a1) + var e interface{} = X(0) + a5 := e.(I1) + a6 := e.(I2) + isfalse(a1 == b1) + isfalse(a1 == b2) + isfalse(a2 == b1) + isfalse(a2 == b2) + istrue(a1 == a2) + istrue(a1 == a3) + istrue(a1 == a4) + istrue(a1 == a5) + istrue(a1 == a6) + istrue(a2 == a3) + istrue(a2 == a4) + istrue(a2 == a5) + istrue(a2 == a6) + istrue(a3 == a4) + istrue(a3 == a5) + istrue(a3 == a6) + istrue(a4 == a5) + istrue(a4 == a6) + istrue(a5 == a6) + } + // non-interface comparisons { c := make(chan int) |