| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
| |
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6742053
|
|
|
|
|
|
|
|
|
|
|
|
| |
In recent Python versions .reason is a read-only property that simply gives you the msg value.
Fixes issue 4024
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/6545052
Committer: Shenghou Ma <minux.ma@gmail.com>
|
|
|
|
|
|
|
|
| |
Fixes issue 4131.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6614061
|
|
|
|
|
|
|
|
|
|
| |
Continuation of http://codereview.appspot.com/6499053/
R=golang-dev, minux.ma
CC=golang-dev
http://codereview.appspot.com/6584059
Committer: Rob Pike <r@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue 4121.
R=golang-dev, minux.ma, dave, r
CC=golang-dev
http://codereview.appspot.com/6555049
Committer: Shenghou Ma <minux.ma@gmail.com>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The decorator hides the number of function arguments from Mercurial,
so Mercurial cannot give proper error messages about commands
invoked with the wrong number of arguments.
Left a 'dummy' hgcommand decorator in place as a way to document
what functions are hg commands, and just in case we need some other
kind of hack in the future.
R=adg, rsc
CC=golang-dev
http://codereview.appspot.com/6488059
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
We explicitly use plainformatter to avoid the
user's debug setting changing our behavior.
Fixes issue 3603.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/6201069
|
|
|
|
|
|
|
|
| |
R=adg
CC=golang-dev
http://codereview.appspot.com/6127048
Committer: Andrew Gerrand <adg@golang.org>
|
|
|
|
|
|
|
|
|
| |
Docstrings were not being set for the wrapper
functions returned by the hgcommand decorator.
R=golang-dev, minux.ma, rsc
CC=golang-dev
http://codereview.appspot.com/6059043
|
|
|
|
|
|
|
|
| |
Fixes issue 3430.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5981047
|
|
|
|
|
|
|
|
|
| |
Mercurial: the Python of version control systems.
Python: the Mercurial of programming languages.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5777066
|
|
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5689063
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
| |
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5620053
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5623045
|
|
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5622043
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
| |
R=golang-dev, gri
CC=golang-dev
http://codereview.appspot.com/5581047
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5596046
|
|
|
|
|
|
|
|
|
|
| |
If this happens, something is misconfigured.
If we don't test for this explicitly, MatchAt ends
up calling itself recursively forever.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5576066
|
|
|
|
|
|
|
|
| |
Python and Mercurial are a matched pair.
R=adg
CC=golang-dev
http://codereview.appspot.com/5570065
|
|
|
|
|
|
| |
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5564054
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue 2569 (hg undo crashes when CL not found).
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5489052
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5487057
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Gives other projects the benefit of the gofmt presubmit.
Results in minor changes in the doc/ directory:
find doc -name \*.go -exec gofmt -d {} \;
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/5158042
Committer: Robert Griesemer <gri@golang.org>
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5417049
|
|
|
|
|
|
|
|
| |
Update version check from 1.4 to 1.9. Suggest 2.0.
R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/5413046
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks with hg 1.6.4. Roll back until it's fixed.
??? original CL description
codereview: cleanup + basic tests
R=adg, bradfitz
CC=golang-dev
http://codereview.appspot.com/5395044
???
R=golang-dev
CC=golang-dev
http://codereview.appspot.com/5410047
|
|
|
|
|
|
| |
R=adg, bradfitz
CC=golang-dev
http://codereview.appspot.com/5395044
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Shows first line of any response that the codereview server
has identified as an LGTM. Example output below.
5305046:
big: update for fmt interface changes
Nothing terribly interesting here.
Reviewer: gri@golang.org
gri: LGTM
CC: golang-dev@googlegroups.com
Files:
src/pkg/big/int.go
src/pkg/big/nat.go
src/pkg/big/nat_test.go
src/pkg/big/rat.go
5307044:
exp/template/html: use rune
Nothing terribly interesting here.
Reviewer: mikesamuel@gmail.com, nigeltao@golang.org
mikesamuel: I don't see a type def for rune. Assuming that's a new intrinsic, LGTM.
CC: golang-dev@googlegroups.com
Files:
src/pkg/exp/template/html/css.go
src/pkg/exp/template/html/css_test.go
src/pkg/exp/template/html/html.go
src/pkg/exp/template/html/js.go
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5297045
|
|
|
|
|
|
| |
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/5127052
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
lib/codereview: Unable to use vim for 'hg change' from windows console
reload(sys) break workaround for windows.
see:
http://mercurial.selenic.com/bts/issue2888
http://mercurial.selenic.com/bts/issue1452
Also does not work with backslash paths.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5150054
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Also work around Mercurial issue 3023.
If anyone has local changes in their repo (due to
patch queues or whatever) stop them from leaking
into the main repository.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5144043
|
|
|
|
|
|
|
|
| |
Fixes issue 2279.
R=bradfitz, r, r
CC=golang-dev
http://codereview.appspot.com/5096042
|
|
|
|
|
|
| |
R=golang-dev, adg
CC=golang-dev
http://codereview.appspot.com/4969063
|
|
|
|
|
|
|
|
|
| |
Not sure how to detect read-only but at least
this pins the blame on the hg server.
R=r, bradfitz
CC=golang-dev
http://codereview.appspot.com/4847053
|
|
|
|
|
|
|
|
| |
R=golang-dev, mirtchovski, mikioh.mikioh
CC=golang-dev
http://codereview.appspot.com/4686049
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Breaks Mercurial 1.8.3.
??? original CL description
codereview: fix for Mercurial 1.9
Fixes issue 2038.
R=rsc, bobbypowers
CC=golang-dev
http://codereview.appspot.com/4675045
???
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4685055
|
|
|
|
|
|
|
|
| |
Fixes issue 2038.
R=rsc, bobbypowers
CC=golang-dev
http://codereview.appspot.com/4675045
|
|
|
|
|
|
|
|
|
| |
'default' is the name of the main branch,
the one that isn't a release branch.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4636072
|
|
|
|
|
|
| |
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/4627067
|
|
|
|
|
|
|
|
| |
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/4644043
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4543046
|
|
|
|
|
|
| |
TBR=gri
CC=golang-dev
http://codereview.appspot.com/4534052
|
|
|
|
|
|
|
|
| |
Fixes hg clpatch.
R=golang-dev, r, r
CC=golang-dev
http://codereview.appspot.com/4524045
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Note that if you are working on the upcoming release
branch you have to point your extension path to a
copy of lib/codereview/codereview.py that won't change
as the repository flips between release-branch and default branch.
This warning should only apply to this one branch and only to rsc,
but you never know.
R=adg
CC=golang-dev
http://codereview.appspot.com/4446076
|
|
|
|
|
|
|
|
|
|
| |
Set mailed bit correctly for self-clpatch.
Use repo.rollback correctly.
Allow leading spaces in some C code.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4438064
|
|
|
|
|
|
| |
R=adg, r
CC=golang-dev
http://codereview.appspot.com/4423045
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
In the current codereview, if a patch was written against
a version of a file that had subsequently been edited,
hg clpatch would fail, even if the patch and the edits were
in different parts of the file. In this situation the reviewer
typically wrote back saying "please hg sync and hg mail
to update the patch".
This change rewrites the patch automatically, using the
same transformation that hg sync + hg mail would.
If the interim changes (since the patch was created)
affect the same line ranges as the patch, clpatch will
still refuse to apply it. But this CL should make
of the trivial conflicts we see just go away.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4377046
|
|
|
|
|
|
|
|
| |
I love Python. Write once, crash anywhere.
TBR=r
CC=golang-dev
http://codereview.appspot.com/4382043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Right now if a Go developer makes a patch on one machine
and then clpatches it onto another machine, changes
subsequently made to the description are kept only
locally, under the assumption that you are running
clpatch because someone else wrote the CL, so you
don't have permission to update the web.
This change makes clpatch discard the "this was a
clpatch" information from the metadata when you
clpatch your own CLs from one machine to another.
This should eliminate some confusion (for example
in CL 4314054) but will no doubt introduce other
confusion.
R=golang-dev, r2
CC=golang-dev
http://codereview.appspot.com/4387041
|
|
|
|
|
|
| |
R=adg
CC=golang-dev
http://codereview.appspot.com/4385042
|