summaryrefslogtreecommitdiff
path: root/lib/codereview/codereview.py
Commit message (Collapse)AuthorAgeFilesLines
* [dev.garbage] all: merge default (f38460037b72) into dev.garbageRuss Cox2014-11-141-5/+11
|\ | | | | | | | | | | | | | | | | This is the revision that dev.cc is branched from. LGTM=austin R=austin CC=golang-codereviews https://codereview.appspot.com/169590043
| * [dev.garbage] all: merge dev.power64 (5ad5e85cfb99) into dev.garbageRuss Cox2014-10-291-3/+9
| |\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The goal here is to get the big-endian fixes so that in some upcoming code movement for write barriers I don't make them unmergeable. LGTM=rlh R=rlh CC=golang-codereviews https://codereview.appspot.com/166890043
| | * [dev.power64] build: merge default into dev.power64Austin Clements2014-10-221-3/+9
| | | | | | | | | | | | | | | | | | | | | LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/160200044
| * | [dev.garbage] lib/codereview: allow hg submit to commit new branch if CL ↵Russ Cox2014-09-251-2/+2
| |/ | | | | | | | | | | | | | | | | | | | | | | description says so This means I won't have to edit the plugin when I create the next dev branch. LGTM=r, adg R=r, adg CC=golang-codereviews https://codereview.appspot.com/148950045
* | all: use golang.org/x/... import pathsAndrew Gerrand2014-11-101-1/+1
| | | | | | | | | | | | | | LGTM=rsc, r R=r, rsc CC=golang-codereview, golang-codereviews https://codereview.appspot.com/168050043
* | lib/codereview: fix with more recent hg revisions.Adam Langley2014-11-081-0/+1
|/ | | | | | | | | | | | | | | | | | | | | I've Mercurial version 3.2 and hg submit fails with: File "/home/agl/devel/go/lib/codereview/codereview.py", line 3567, in get_hg_status ret = hg_commands.status(fui, self.repo, *[], **{'rev': [rev], 'copies': True}) File "/usr/lib/python2.7/site-packages/mercurial/commands.py", line 5714, in status fm = ui.formatter('status', opts) File "/home/agl/devel/go/lib/codereview/codereview.py", line 3464, in formatter return plainformatter(self, topic, opts) File "/usr/lib/python2.7/site-packages/mercurial/formatter.py", line 57, in __init__ if ui.debugflag: AttributeError: 'FakeMercurialUI' object has no attribute 'debugflag' This change dumbly adds a boolean debugflag and that seems to work. LGTM=minux R=rsc, minux CC=golang-codereviews https://codereview.appspot.com/167410043
* codereview: do not hit upload_complete on first patchRuss Cox2014-08-061-1/+2
| | | | | | | | Causes server 500 error, so don't do it. TBR=minux CC=golang-codereviews https://codereview.appspot.com/125770043
* codereview: fix submit of merge + include branch prefix in submitted messageRuss Cox2014-08-061-8/+21
| | | | | | | | | | | | hg insists that we not list explicit files for a merge. for benefit of other tools reading logs, include branch prefix at start of every commit message. LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/124780044
* codereview: handle upload of mergeRuss Cox2014-08-061-3/+15
| | | | | | | LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/118690043
* codereview: preserve branch prefix in subject during hg mailRuss Cox2014-08-061-8/+10
| | | | | | | LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/124800043
* codereview: enable work and code reviews in development branchesRuss Cox2014-08-061-5/+17
| | | | | | | | | | This is an experiment. See mail on golang-dev (subject: "an experiment: development branches"). LGTM=minux R=minux CC=golang-codereviews https://codereview.appspot.com/117660043
* codereview: abort 'hg commit' before entering commit message.Shenghou Ma2014-07-181-4/+4
| | | | | | | | | | Hook pre-commit runs before 'hg commit' command whereas hook precommit runs after the user has entered commit message. LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/106320043
* codereview: revive the tests.Shenghou Ma2014-07-181-4/+20
| | | | | | | LGTM=rsc R=rsc CC=golang-codereviews https://codereview.appspot.com/105500043
* codereview: update name of the a+c toolBrad Fitzpatrick2014-07-011-1/+1
| | | | | | | LGTM=rsc R=rsc, minux CC=golang-codereviews https://codereview.appspot.com/105480043
* lib/codereview: fix doc/go1.*.txt exceptionRuss Cox2014-06-121-1/+1
| | | | | | | LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/108950046
* codereview: no LGTM needed for doc/go1.x.txtRuss Cox2014-06-121-3/+13
| | | | | | | | | | Rob asked for this change to make maintaining go1.4.txt easier. If you are not sure of a change, it is still okay to send for review. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/109880044
* codereview: do not add defaultcc for private CLsRuss Cox2014-06-051-2/+2
| | | | | | | LGTM=r R=r, 0xjnml, bradfitz, iant CC=golang-codereviews https://codereview.appspot.com/103070046
* codereview: remove unused upload_options.revisionPatrick M?zard2014-02-241-12/+9
| | | | | | | | | LGTM=rsc R=golang-codereviews, rsc CC=golang-codereviews https://codereview.appspot.com/60640052 Committer: Russ Cox <rsc@golang.org>
* codereview: fix for Mercurial 2.9Anthony Martin2014-02-141-1/+1
| | | | | | | | | | | | The branchtags method was removed but we should've been using branchmap all along. http://selenic.com/hg/rev/4274eda143cb LGTM=franciscossouza, r R=golang-codereviews, franciscossouza, r CC=golang-codereviews https://codereview.appspot.com/57500045
* codereview: warn about 'hg upload' not uploadingRuss Cox2014-02-131-0/+2
| | | | | | | | | | | | This seems to be what causes the 'chunk mismatch' errors. I don't know why the server tells us there's nothing to upload, but at the least we can warn that it did, so that the user will try again. LGTM=bradfitz R=golang-codereviews, bradfitz CC=golang-codereviews https://codereview.appspot.com/62840043
* lib/codereview: allow addca CLs without LGTMRuss Cox2014-02-101-1/+6
| | | | | | | LGTM=gri R=golang-codereviews, gri CC=golang-codereviews https://codereview.appspot.com/61610043
* lib/codereview: add LGTM= line to commit messagesRuss Cox2014-01-231-5/+20
| | | | | | | | | | | The R= is populated by Rietveld, so it's basically anyone who replied to the CL. The LGTM= is meant to record who actually signed off on the CL. LGTM=r R=r CC=golang-codereviews https://codereview.appspot.com/55390043
* plan9: correct create permissions with union directoryJeff Sickel2013-10-231-1/+1
| | | | | | | | R=golang-dev, rsc CC=golang-dev https://codereview.appspot.com/15360045 Committer: Russ Cox <rsc@golang.org>
* lib/codereview: return an empty list when CONTRIBUTORS is not found instead ↵Francesc Campoy2013-10-101-1/+1
| | | | | | | | of None. R=adg, campoy, r CC=golang-dev https://codereview.appspot.com/14419059
* codereview: fix hg sync closing of CLs for subrepositoriesDominik Honnef2013-10-101-1/+1
| | | | | | | | | | | | The regexp for closing CLs that were sent by you but committed by someone else only matched messages for the main repository, because of the added &repo=... for subrepositories. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/14512045 Committer: Rob Pike <r@golang.org>
* codereview: move dotfiles out of user home director to something sane.Jeff Sickel2013-10-071-0/+8
| | | | | | | | | | See Rob Pike's lesson on shortcuts, https://plus.google.com/101960720994009339267/posts/R58WgWwN9jp R=golang-dev, r, rsc CC=aram.h, golang-dev https://codereview.appspot.com/14374045 Committer: Russ Cox <rsc@golang.org>
* codereview: update use of promptchoice for Mercurial 2.7Anthony Martin2013-09-061-1/+4
| | | | | | | | | | Fixes issue 6186. R=golang-dev, bradfitz, remyoudompheng, rsc CC=golang-dev https://codereview.appspot.com/13112043 Committer: Russ Cox <rsc@golang.org>
* codereview: force hg update after hg pull -u during hg syncRuss Cox2013-06-251-1/+32
| | | | | | | | | | | If you hg update your client to an earlier CL, then hg sync will move you back to tip if it pulls anything in, but it will leave you where you are if it doesn't pull anything in. That's confusing: make hg sync always update to tip. R=golang-dev, bradfitz, r, dsymonds CC=golang-dev https://codereview.appspot.com/10456044
* codereview: don't warn about secret commitsAnthony Martin2013-06-041-2/+6
| | | | | | | | | | | | | | | | | | | | | Normally the codereview plugin disables adding new commits when not using the submit command. Unfortunately this makes it impossible to use the Mercurial Queues extension at the same time. A feature called "Phases" was introduced in Mercurial 2.1 that allows marking commits as being secret; this means they will never be pushed to the upstream repository. We can take advantage of this feature to allow the use of Mercurial Queues if the mq.secret option has been set in hgrc(5) and a recent version of Mercurial is used. R=golang-dev, rsc, minux.ma CC=golang-dev https://codereview.appspot.com/7398055 Committer: Brad Fitzpatrick <bradfitz@golang.org>
* codereview.py: improve error message when user is not a committerFrancesc Campoy2013-05-221-0/+3
| | | | | | R=adg, bradfitz, r CC=golang-dev https://codereview.appspot.com/9626045
* lib/codereview/codereview.py: fix crash when hg gofmt has no filesRob Pike2013-03-261-1/+2
| | | | | | | | | The gofmt function was returning a string, which isn't the right type. Three cheers for dynamic typing. R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7917044
* codereview: re-enable 15-second status printsRuss Cox2013-03-151-1/+3
| | | | | | | | | | | | Also print all status changes when using hg -v. The start_status_thread call was lost during the refactoring in https://codereview.appspot.com/5395044/diff/6006/lib/codereview/codereview.py Oops. R=golang-dev, r CC=golang-dev https://codereview.appspot.com/7834044
* codereview: give up on http fetch after 30 secondsRuss Cox2013-02-191-0/+2
| | | | | | | | | | | | | | If Python blocks in the SSL handshake it seems to be completely uninterruptible, and I've been seeing it block for at least hours recently. I don't know if the problem is on the client side or the server side or somewhere in the network, but setting the timeout at least means you're guaranteed a new shell prompt (after printing some errors). R=golang-dev, bradfitz, minux.ma CC=golang-dev https://codereview.appspot.com/7337048
* codereview: use hgapplydiff instead of hgpatchRuss Cox2013-02-071-9/+9
| | | | | | | | Depends on https://codereview.appspot.com/7308067 R=golang-dev, bradfitz CC=golang-dev https://codereview.appspot.com/7312064
* codereview: show 'not lgtms' in hg p output (with lgtms)Russ Cox2013-01-291-1/+1
| | | | | | R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/7245043
* lib/codereview: suggest argument to hg mail / hg submitRuss Cox2012-12-111-4/+4
| | | | | | R=golang-dev, iant CC=golang-dev https://codereview.appspot.com/6924050
* codereview: always use HTTPSBrad Fitzpatrick2012-11-291-9/+9
| | | | | | | | | | The new version of rietveld pushed 1.5 hours ago requires HTTPS now, otherwise it issues a 301 to HTTPS which we barfed on. R=golang-dev CC=golang-dev https://codereview.appspot.com/6782135
* codereview: protect against read-only upstream repositoryShenghou Ma2012-10-201-1/+2
| | | | | | R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/6742053
* codereview.py: Fix crash on auth error handling.Uriel Mangado2012-10-111-9/+11
| | | | | | | | | | | | In recent Python versions .reason is a read-only property that simply gives you the msg value. Fixes issue 4024 R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/6545052 Committer: Shenghou Ma <minux.ma@gmail.com>
* codereview: more mercurial interface fixesShenghou Ma2012-10-081-14/+14
| | | | | | | | Fixes issue 4131. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6614061
* codereview.py: suggest installing Mercurial from official websiteRobert Hencke2012-10-031-5/+1
| | | | | | | | | | Continuation of http://codereview.appspot.com/6499053/ R=golang-dev, minux.ma CC=golang-dev http://codereview.appspot.com/6584059 Committer: Rob Pike <r@golang.org>
* codereview: use subprocess.call() instead of os.spawnvp() for portabilityShivakumar GN2012-09-271-1/+1
| | | | | | | | | | Fixes issue 4121. R=golang-dev, minux.ma, dave, r CC=golang-dev http://codereview.appspot.com/6555049 Committer: Shenghou Ma <minux.ma@gmail.com>
* codereview.py: correct error handling without decoratorUriel Mangado2012-09-011-45/+32
| | | | | | | | | | | | | | | | The decorator hides the number of function arguments from Mercurial, so Mercurial cannot give proper error messages about commands invoked with the wrong number of arguments. Left a 'dummy' hgcommand decorator in place as a way to document what functions are hg commands, and just in case we need some other kind of hack in the future. R=adg, rsc CC=golang-dev http://codereview.appspot.com/6488059 Committer: Russ Cox <rsc@golang.org>
* codereview: support mercurial 2.2.1Shenghou Ma2012-05-171-0/+4
| | | | | | | | | | We explicitly use plainformatter to avoid the user's debug setting changing our behavior. Fixes issue 3603. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/6201069
* codereview: look for new release branchesRuss Cox2012-04-251-6/+5
| | | | | | | | R=adg CC=golang-dev http://codereview.appspot.com/6127048 Committer: Andrew Gerrand <adg@golang.org>
* codereview: restore help messagesAnthony Martin2012-04-171-0/+1
| | | | | | | | | Docstrings were not being set for the wrapper functions returned by the hgcommand decorator. R=golang-dev, minux.ma, rsc CC=golang-dev http://codereview.appspot.com/6059043
* codereview: give advice on 'cannot create CL outside default branch'Russ Cox2012-04-021-1/+1
| | | | | | | | Fixes issue 3430. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5981047
* codereview: fix for Mercurial 2.1Russ Cox2012-03-121-0/+33
| | | | | | | | | Mercurial: the Python of version control systems. Python: the Mercurial of programming languages. R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5777066
* codereview: add submit message support for newer clone URL and subreposShenghou Ma2012-02-211-2/+10
| | | | | | | | R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5689063 Committer: Russ Cox <rsc@golang.org>
* codereview: allow spaces in y.tab.[ch]Russ Cox2012-02-031-1/+1
| | | | | | R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5620053
View Lorry Controller Status