summaryrefslogtreecommitdiff
path: root/lib/codereview/codereview.py
Commit message (Collapse)AuthorAgeFilesLines
...
* codereview: more utf-8 nonsenseRuss Cox2010-11-041-11/+69
| | | | | | | | To annoy hg: ????? ?? ??? ???????? ?????? ????? ?? ???? ??????. R=r CC=golang-dev http://codereview.appspot.com/2900041
* codereview: fix 'hg sync' and 'hg download' in Python 2.7Fazlul Shahriar2010-11-011-2/+2
| | | | | | | | | | Fixes issue 1218. R=rsc CC=golang-dev http://codereview.appspot.com/2664041 Committer: Russ Cox <rsc@golang.org>
* misc: update python scripts to specify python2 or nothingAndrew Gerrand2010-10-211-2/+0
| | | | | | | | | | (Hopefully this changeset will notice my +x to googlecode_upload.py) Fixes issue 1217. R=rsc CC=golang-dev http://codereview.appspot.com/2634041
* codereview: disallow submit of *.[chys] files indented with spacesRuss Cox2010-10-061-4/+34
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/2383041
* codereview: fix upload of hg copied fileRuss Cox2010-09-281-1/+1
| | | | | | | | Fixes issue 1134. R=r, r2 CC=golang-dev http://codereview.appspot.com/2264043
* codereview: convert email address from Rietveld to lower caseRuss Cox2010-09-111-1/+2
| | | | | | | | before looking for it in the CONTRIBUTORS file R=r CC=golang-dev http://codereview.appspot.com/1883049
* codereview: Fix uploading for Mercurial 1.6.3Evan Shaw2010-08-291-2/+2
| | | | | | | | | | | | See: http://selenic.com/repo/hg/rev/32b213b9b22c http://selenic.com/repo/hg/rev/2096496b40ec R=rsc, adg CC=golang-dev http://codereview.appspot.com/2072041 Committer: Russ Cox <rsc@golang.org>
* codereview: speed uploadRuss Cox2010-08-261-29/+80
| | | | | | | | | Cuts time to upload trivial 160-file CL by 5x, from 250 seconds to 50 seconds. R=r CC=golang-dev http://codereview.appspot.com/1991047
* codereview: consistent indent, cut dead codeRuss Cox2010-08-261-1478/+784
| | | | | | | | | | | | | | End the charade (farce?) that we are using upload.py unaltered. Cut all the unused stuff. Indent using tabs to match the rest of the file. Next: rewrite MercurialVCS to use mercurial package, to avoid overhead of forking off a new hg command multiple times for every file. And parallelize upload. R=gri CC=golang-dev http://codereview.appspot.com/2009046
* codereview: fix hang on standard hg commandsRuss Cox2010-08-261-1/+3
| | | | | | R=gri CC=golang-dev http://codereview.appspot.com/1950045
* codereview: print status when hungRuss Cox2010-08-261-0/+49
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After 30 seconds, start printing status updates, so that we can see whether hg is making progress. $ hg upload 1983051 Thu Aug 26 15:06:15 2010 running gofmt Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go http://codereview.appspot.com/1983051 $ R=gri CC=golang-dev http://codereview.appspot.com/2020045
* codereview: really disable codereview when not availableRuss Cox2010-08-251-21/+50
| | | | | | | | | | $ hg p codereview disabled: cannot open /Users/rsc/g/go/src/pkg/goplan9.googlecode.com/hg/lib/codereview/codereview.cfg $ R=dsymonds, r CC=golang-dev http://codereview.appspot.com/1998046
* codereview: do not send "Abanoned" mail if this CL hasRuss Cox2010-08-121-1/+1
| | | | | | | | not been mailed out for review. R=r CC=golang-dev http://codereview.appspot.com/1962046
* codereview.py: Fix issues with leading tabulation in the Files: section of ↵Ivan Krasin2010-08-121-0/+1
| | | | | | | | | | CL description. R=imkrasin, rsc CC=golang-dev http://codereview.appspot.com/1943042 Committer: Russ Cox <rsc@golang.org>
* codereview: avoid crash if no configRuss Cox2010-07-261-1/+5
| | | | | | | | Fixes issue 959. R=r CC=golang-dev http://codereview.appspot.com/1876045
* codereview: make 'hg submit' work with Mercurial 1.6Russ Cox2010-07-161-1/+7
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/1841044
* codereview: don't run gofmt with an empty file listRuss Cox2010-07-151-0/+2
| | | | | | R=gri CC=golang-dev http://codereview.appspot.com/1678054
* codereview: Fix for Mercurial >= 1.6Evan Shaw2010-07-141-2/+6
| | | | | | | | R=rsc, adg, rsc1 CC=golang-dev http://codereview.appspot.com/1804041 Committer: Russ Cox <rsc@golang.org>
* codereview: allow multiple email addresses in CONTRIBUTORSRuss Cox2010-06-301-17/+33
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/1650041
* codereview: avoid exception in matchPaolo Giarrusso2010-06-091-1/+2
| | | | | | | | R=rsc CC=golang-dev http://codereview.appspot.com/1585041 Committer: Russ Cox <rsc@golang.org>
* codereview: work better with mqPeter Williams2010-05-241-4/+14
| | | | | | | | R=rsc CC=golang-dev http://codereview.appspot.com/1140043 Committer: Russ Cox <rsc@golang.org>
* codereview: Mention that deleting a CL is a use of 'hg change' in its header.David Symonds2010-04-101-2/+2
| | | | | | | | R=rsc CC=golang-dev http://codereview.appspot.com/903043 Committer: Russ Cox <rsc@golang.org>
* codereview.py: fix for compatibility with hg >=1.4.3Andrew Gerrand2010-03-031-1/+1
| | | | | | | | | hg.parseurl now returns a two-value tuple; codereview.py expected 3. Changed to merely take the first return value. R=rsc, iant CC=golang-dev http://codereview.appspot.com/223087
* codereview: make sure each mail has a reviewerRuss Cox2010-01-281-2/+10
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/196050
* codereview: correct handling of files created with hg cpRuss Cox2010-01-271-5/+2
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/194118
* codereview: accommodate recent change to ui.promptRuss Cox2010-01-201-2/+11
| | | | | | | | Fixes issue 525. R=r CC=golang-dev http://codereview.appspot.com/190044
* codereview: split name list only on commas; some user names have spacesRuss Cox2010-01-131-15/+16
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/184069
* codereview: do not send mail when submitting for othersRuss Cox2010-01-091-20/+20
| | | | | | | | | rename original_author to copied_from so that it reads better when used as a condition. R=r CC=golang-dev http://codereview.appspot.com/185045
* codereview: repeated hg mail sends "PTAL"Russ Cox2010-01-071-9/+29
| | | | | | | | also send out hg mail for TBR submits R=r CC=golang-dev http://codereview.appspot.com/183137
* codereview: add golang-dev@googlegroups.comRuss Cox2009-12-151-40/+33
| | | | | | | | | automatically in "hg mail". also, avoid "empty list means all modified files in client" bug R=gri, cw CC=golang-dev http://codereview.appspot.com/174072
* Ported godefs to Windows.Hector Chu2009-12-131-0/+2
| | | | | | | R=rsc http://codereview.appspot.com/164049 Committer: Russ Cox <rsc@golang.org>
* codereview: do not gofmt deleted filesRuss Cox2009-12-031-0/+1
| | | | | R=r http://codereview.appspot.com/164083
* codereview: move reviewers to cc line after submit,Russ Cox2009-12-021-11/+18
| | | | | | | | so that the issue stops showing up on the per-reviewer dashboard page. R=r http://codereview.appspot.com/164075
* lxml.etree is the wrong location for this alt packageDevon H. O'Dell2009-12-021-1/+1
| | | | | | | | | | | on my linux machine this is the correct one. lxml.etree exists with an ElementTree class, but does not contain an .XML method. R=rsc http://codereview.appspot.com/163082 Committer: Russ Cox <rsc@golang.org>
* xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3)Devon H. O'Dell2009-12-021-1/+4
| | | | | | | | R=rsc CC=golang-dev http://codereview.appspot.com/164053 Committer: Russ Cox <rsc@golang.org>
* Ports of lib9, libbio and libmach to Windows.Hector Chu2009-11-301-1/+1
| | | | | | | R=rsc http://codereview.appspot.com/157159 Committer: Russ Cox <rsc@golang.org>
* codereview: allow editing of local CL descriptionRuss Cox2009-11-301-1/+8
| | | | | | | between hg clpatch and hg submit. R=r http://codereview.appspot.com/162059
* gofmt -r '?[?:len(?)] -> ?[?:]' -w test/benchRuss Cox2009-11-201-1/+2
| | | | | | | | | except chameneosredux which i know is being edited require gofmt for test/bench R=r http://codereview.appspot.com/157110
* codereview: handle UTF-8 in message descriptionsRuss Cox2009-11-201-1/+1
| | | | | | | what a terrible way to implement strings R=r http://codereview.appspot.com/156116
* codereview: make hg sync work with Mercurial 1.4Russ Cox2009-11-201-10/+21
| | | | | R=r http://codereview.appspot.com/157102
* codereview: more attempts at robustness in the face of unexpected exceptionsRuss Cox2009-11-171-36/+39
| | | | | R=r http://codereview.appspot.com/156062
* codereview: handle spaces and other unexpected chars in nicknamesRuss Cox2009-11-171-1/+3
| | | | | R=r http://codereview.appspot.com/157053
* case insensitive matching in CONTRIBUTORS fileRob Pike2009-11-171-1/+1
| | | | | R=rsc http://codereview.appspot.com/157043
* codereview: discard \r characters (sigh)Russ Cox2009-11-171-0/+2
| | | | | R=r http://codereview.appspot.com/157041
* codereview: add clpatch --ignore_hgpatch_errors.Russ Cox2009-11-171-1/+2
| | | | | | | | | of limited utility but good for creating the metadata for an AUTHORS/CONTRIBUTORS change even if the patch doesn't apply cleanly. R=r http://codereview.appspot.com/154140
* Pass ui into PostMessage to avoid nasty/confusing exceptionDevon H. O'Dell2009-11-171-4/+4
| | | | | | | R=rsc http://codereview.appspot.com/155079 Committer: Russ Cox <rsc@golang.org>
* codereview: clpatch tweaksRuss Cox2009-11-121-3/+7
| | | | | R=agl1 http://codereview.appspot.com/152114
* default to codereview.appspot.comRuss Cox2009-11-101-6/+1
| | | | | R=r http://codereview.prom.corp.google.com/1026040
* make hg mail more forgiving:Russ Cox2009-11-081-2/+7
| | | | | | | | create CL first, even if gofmt is needed or no reviewers listed. R=r http://go/go-review/1025025
* assorted cleanupRuss Cox2009-11-081-1/+9
| | | | | | R=r, iant CC=go-dev http://go/go-review/1025024