summaryrefslogtreecommitdiff
path: root/lib/codereview/codereview.py
Commit message (Collapse)AuthorAgeFilesLines
...
* another attempt at utf-8 uploads.Russ Cox2009-11-081-7/+7
| | | | | | | the last attempt broke uploads of binary files like .png R=r http://go/go-review/1026025
* fix authentication in parallel LoadAllCLRuss Cox2009-11-071-4/+11
| | | | | R=r http://go/go-review/1024018
* require Mercurial 1.3 again (how did that get dropped?)Russ Cox2009-11-071-17/+40
| | | | | | | avoid deprecation warning about os.popen3 R=r http://go/go-review/1026018
* codereview: print gofmt message when abortingRuss Cox2009-11-061-3/+3
| | | | | | R=r CC=vish http://go/go-review/1026013
* make temporary google.com -> golang.org hack more sophisticatedRuss Cox2009-11-061-8/+8
| | | | | R=r http://go/go-review/1024013
* require gofmt for all $GOROOT/src/.../*.go.Russ Cox2009-11-061-8/+31
| | | | | | | | try harder to post messages to rietveld. R=gri, r CC=go-dev http://go/go-review/1024006
* fix UTF-8 upload bugRuss Cox2009-11-051-4/+7
| | | | | TBR=r http://go/go-review/1026001
* codereview: new commandsRuss Cox2009-11-051-31/+231
| | | | | | | | | | | | * clpatch * download * submit, on behalf of clpatch stir hgpatch to fix a few bugs R=r CC=go-dev http://go/go-review/1016051
* add -l flag to hg gofmt.Russ Cox2009-11-051-4/+9
| | | | | | | don't apply gofmt to non-go files during upload check. R=r http://go/go-review/1016048
* add "hg gofmt" to run all modified files through gofmt.Russ Cox2009-11-041-12/+93
| | | | | | | | | | | | | | | | | | | add check before Upload, for now disabled by default, that files do not change when run through gofmt. enable by adding [codereview] force_gofmt = True to .hgrc or .hg/hgrc. add doc strings for a few more commands. rename codereview-login to code-login to make module doc visible. R=r CC=gri http://go/go-review/1018056
* avoid infinite recursion in matcher.Russ Cox2009-11-041-15/+79
| | | | | | | | | | after sync (or sync --local), clean up repository: * look for and close CLs submitted on our behalf * remove unmodified files from CLs * warn about empty CLs R=r http://go/go-review/1017029
* various tweaks to code review.Russ Cox2009-11-041-10/+27
| | | | | | | | | | | | | | | | | main one is to check at submit time that user name being used in checkin message is listed in the CONTRIBUTORS file. this should catch misconfigurations. another is to cut the @domain part from the R= and CC= lines on checkin messages, so that cc'ing someone on a change does not mean their email address is recorded for all time. R=r CC=go-dev http://go/go-review/1016036
* rietveld does not like code reviews with subjects longer than 100 ↵Russ Cox2009-11-021-1/+3
| | | | | | | characters, so trim the line pulled out of the description to avoid the limit. R=r http://go/go-review/1016027
* code review: avoid subject changes, fix http_proxy submit bugRuss Cox2009-11-011-11/+25
| | | | | R=r http://go/go-review/1016021
* code review fixesRuss Cox2009-11-011-188/+282
| | | | | | | | | | | | | | | | * clean up error handling: show Exception info * white space fixes * clean up output when creating CL * simplify hg change command; add hg file * fix stale cookie bug (thanks iant) * in LoadAllCL, load each CL in a different thread, to parallelize the slow web fetches * throw away support for Mercurial before version 1.3 * add @CL-number file pattern for commands like diff * make hg sync show files being sync'ed R=r http://go/go-review/1016016
* add codereview-login commandRuss Cox2009-10-221-0/+15
| | | | | | R=r CC=go-dev http://go/go-review/1012007
* fix handling of escaped characters like ' " & < >Russ Cox2009-10-221-4/+3
| | | | | R=r http://go/go-review/1013007
* Initial checkin of codereview plugin.Russ Cox2009-10-221-0/+2575
The master copy is going to live elsewhere, but weAPOSTROPHEll keep a copy in the Go tree so that developers donAPOSTROPHEt have to check out two different repositories. R=r CC=go-dev http://go/go-review/1012006