summaryrefslogtreecommitdiff
path: root/lib/codereview
Commit message (Collapse)AuthorAgeFilesLines
...
* codereview: allow spaces in y.tab.[ch]Russ Cox2012-02-031-1/+1
| | | | | | R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/5620053
* codereview: explain how to get hgpatch in error messageBrad Fitzpatrick2012-02-021-1/+1
| | | | | | R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5623045
* codereview: don't check default paths when codereview disabledAndrew Gerrand2012-02-021-5/+5
| | | | | | | | R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5622043 Committer: Russ Cox <rsc@golang.org>
* codereview: ignore test files during 'hg gofmt'Russ Cox2012-01-301-2/+5
| | | | | | R=golang-dev, gri CC=golang-dev http://codereview.appspot.com/5581047
* codereview: fix initialization checkRuss Cox2012-01-291-1/+4
| | | | | | R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5596046
* codereview: die if initialized twiceRuss Cox2012-01-291-0/+11
| | | | | | | | | | If this happens, something is misconfigured. If we don't test for this explicitly, MatchAt ends up calling itself recursively forever. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5576066
* codereview: more fixesRuss Cox2012-01-251-4/+3
| | | | | | | | Python and Mercurial are a matched pair. R=adg CC=golang-dev http://codereview.appspot.com/5570065
* codereview: support for subrepositoriesRuss Cox2012-01-251-18/+43
| | | | | | R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5564054
* codereview: Initialize "found" in codereview.py.Miki Tebeka2011-12-161-0/+1
| | | | | | | | | | Fixes issue 2569 (hg undo crashes when CL not found). R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5489052 Committer: Russ Cox <rsc@golang.org>
* codereview: fix path slash issue.Yasuhiro Matsumoto2011-12-131-6/+11
| | | | | | | | R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5487057 Committer: Russ Cox <rsc@golang.org>
* codereview: gofmt check for non-src/ filesDavid Crawshaw2011-11-181-1/+1
| | | | | | | | | | | | Gives other projects the benefit of the gofmt presubmit. Results in minor changes in the doc/ directory: find doc -name \*.go -exec gofmt -d {} \; R=rsc, gri CC=golang-dev http://codereview.appspot.com/5158042 Committer: Robert Griesemer <gri@golang.org>
* codereview: put message back in post-commit mailsRuss Cox2011-11-181-1/+1
| | | | | | R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5417049
* codereview: undo last night's rollbackRuss Cox2011-11-182-518/+825
| | | | | | | | Update version check from 1.4 to 1.9. Suggest 2.0. R=golang-dev, r, r CC=golang-dev http://codereview.appspot.com/5413046
* undo CL 5395044 / d88e746d3785Andrew Gerrand2011-11-182-818/+518
| | | | | | | | | | | | | | | | Breaks with hg 1.6.4. Roll back until it's fixed. ??? original CL description codereview: cleanup + basic tests R=adg, bradfitz CC=golang-dev http://codereview.appspot.com/5395044 ??? R=golang-dev CC=golang-dev http://codereview.appspot.com/5410047
* codereview: cleanup + basic testsRuss Cox2011-11-182-518/+818
| | | | | | R=adg, bradfitz CC=golang-dev http://codereview.appspot.com/5395044
* codereview: show LGTMs in hg pRuss Cox2011-10-191-0/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Shows first line of any response that the codereview server has identified as an LGTM. Example output below. 5305046: big: update for fmt interface changes Nothing terribly interesting here. Reviewer: gri@golang.org gri: LGTM CC: golang-dev@googlegroups.com Files: src/pkg/big/int.go src/pkg/big/nat.go src/pkg/big/nat_test.go src/pkg/big/rat.go 5307044: exp/template/html: use rune Nothing terribly interesting here. Reviewer: mikesamuel@gmail.com, nigeltao@golang.org mikesamuel: I don't see a type def for rune. Assuming that's a new intrinsic, LGTM. CC: golang-dev@googlegroups.com Files: src/pkg/exp/template/html/css.go src/pkg/exp/template/html/css_test.go src/pkg/exp/template/html/html.go src/pkg/exp/template/html/js.go R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5297045
* codereview: fix for Mercurial 1.9.2Russ Cox2011-10-051-16/+36
| | | | | | R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/5127052
* codereview: fix hg change in Windows consoleYasuhiro Matsumoto2011-10-051-1/+3
| | | | | | | | | | | | | | | lib/codereview: Unable to use vim for 'hg change' from windows console reload(sys) break workaround for windows. see: http://mercurial.selenic.com/bts/issue2888 http://mercurial.selenic.com/bts/issue1452 Also does not work with backslash paths. R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/5150054 Committer: Russ Cox <rsc@golang.org>
* codereview: extra repo sanity checkRuss Cox2011-09-261-16/+38
| | | | | | | | | | | | Also work around Mercurial issue 3023. If anyone has local changes in their repo (due to patch queues or whatever) stop them from leaking into the main repository. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/5144043
* codereview: save CL messages in $(hg root)/last-changeRuss Cox2011-09-201-0/+12
| | | | | | | | Fixes issue 2279. R=bradfitz, r, r CC=golang-dev http://codereview.appspot.com/5096042
* codereview: Mercurial 1.9 fix for hg diff @nnnRuss Cox2011-09-081-6/+9
| | | | | | R=golang-dev, adg CC=golang-dev http://codereview.appspot.com/4969063
* codereview: set status while committing CLRuss Cox2011-08-101-0/+1
| | | | | | | | | Not sure how to detect read-only but at least this pins the blame on the hg server. R=r, bradfitz CC=golang-dev http://codereview.appspot.com/4847053
* codereview: fix for Mercurial 1.9Andrew Gerrand2011-07-111-8/+18
| | | | | | | | R=golang-dev, mirtchovski, mikioh.mikioh CC=golang-dev http://codereview.appspot.com/4686049 Committer: Russ Cox <rsc@golang.org>
* undo CL 4675045 / 0e11e08951f7Andrew Gerrand2011-07-121-19/+7
| | | | | | | | | | | | | | | | | | Breaks Mercurial 1.8.3. ??? original CL description codereview: fix for Mercurial 1.9 Fixes issue 2038. R=rsc, bobbypowers CC=golang-dev http://codereview.appspot.com/4675045 ??? R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4685055
* codereview: fix for Mercurial 1.9Andrew Gerrand2011-07-121-7/+19
| | | | | | | | Fixes issue 2038. R=rsc, bobbypowers CC=golang-dev http://codereview.appspot.com/4675045
* codereview: restrict sync to default branchRuss Cox2011-06-291-2/+2
| | | | | | | | | 'default' is the name of the main branch, the one that isn't a release branch. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4636072
* codereview: make --ignore_hgpatch_failure work againRuss Cox2011-06-271-4/+6
| | | | | | R=golang-dev, bradfitz CC=golang-dev http://codereview.appspot.com/4627067
* codereview.py: note that hg change -d abandons a change listRobert Hencke2011-06-201-1/+1
| | | | | | | | R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4644043 Committer: Russ Cox <rsc@golang.org>
* codereview: handle 'null as missing field' in rietveld jsonRuss Cox2011-05-131-5/+15
| | | | | | R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4543046
* codereview: fix clpatchRuss Cox2011-05-121-3/+6
| | | | | | TBR=gri CC=golang-dev http://codereview.appspot.com/4534052
* codereview: fetch metadata using JSON API, not XML scrapingRuss Cox2011-05-111-99/+82
| | | | | | | | Fixes hg clpatch. R=golang-dev, r, r CC=golang-dev http://codereview.appspot.com/4524045
* codereview: add release branch supportRuss Cox2011-05-031-13/+127
| | | | | | | | | | | | | Note that if you are working on the upcoming release branch you have to point your extension path to a copy of lib/codereview/codereview.py that won't change as the repository flips between release-branch and default branch. This warning should only apply to this one branch and only to rsc, but you never know. R=adg CC=golang-dev http://codereview.appspot.com/4446076
* codereview: various fixesRuss Cox2011-04-251-3/+18
| | | | | | | | | | Set mailed bit correctly for self-clpatch. Use repo.rollback correctly. Allow leading spaces in some C code. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4438064
* codereview: add 'hg undo' commandRuss Cox2011-04-171-25/+143
| | | | | | R=adg, r CC=golang-dev http://codereview.appspot.com/4423045
* codereview: automatically port old diffs forwardRuss Cox2011-04-081-14/+100
| | | | | | | | | | | | | | | | | | | | | In the current codereview, if a patch was written against a version of a file that had subsequently been edited, hg clpatch would fail, even if the patch and the edits were in different parts of the file. In this situation the reviewer typically wrote back saying "please hg sync and hg mail to update the patch". This change rewrites the patch automatically, using the same transformation that hg sync + hg mail would. If the interim changes (since the patch was created) affect the same line ranges as the patch, clpatch will still refuse to apply it. But this CL should make of the trivial conflicts we see just go away. R=golang-dev, r CC=golang-dev http://codereview.appspot.com/4377046
* codereview: fix clpatchRuss Cox2011-04-071-5/+5
| | | | | | | | I love Python. Write once, crash anywhere. TBR=r CC=golang-dev http://codereview.appspot.com/4382043
* codereview: drop Author: line on self-clpatchRuss Cox2011-04-071-2/+4
| | | | | | | | | | | | | | | | | | | | | Right now if a Go developer makes a patch on one machine and then clpatches it onto another machine, changes subsequently made to the description are kept only locally, under the assumption that you are running clpatch because someone else wrote the CL, so you don't have permission to update the web. This change makes clpatch discard the "this was a clpatch" information from the metadata when you clpatch your own CLs from one machine to another. This should eliminate some confusion (for example in CL 4314054) but will no doubt introduce other confusion. R=golang-dev, r2 CC=golang-dev http://codereview.appspot.com/4387041
* codereview: recognize code URL without trailing slashRuss Cox2011-04-061-1/+1
| | | | | | R=adg CC=golang-dev http://codereview.appspot.com/4385042
* codereview: only retry on HTTP 500 errorRuss Cox2011-04-041-2/+2
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/4353047
* codereview: permit CLs of the form weekly.DATEAndrew Gerrand2011-03-171-1/+1
| | | | | | | | | | gobuilder: recognize CLs of the form weekly.DATE R=rsc, r CC=golang-dev http://codereview.appspot.com/4282052 Committer: Andrew Gerrand <adg@golang.org>
* codereview.py: do not suggest hg change -d if current user is not CL authorRobert Hencke2011-03-081-1/+4
| | | | | | | | R=golang-dev, rsc1, rsc CC=golang-dev http://codereview.appspot.com/4253064 Committer: Russ Cox <rsc@golang.org>
* codereview: fix clpatch with empty diffsGustavo Niemeyer2011-02-231-2/+7
| | | | | | | | | | | | | | Avoid passing the placeholder diff to hgpatch, so that clpatch-ing an empty diff grabs the metadata and warns about it being empty, rather than failing with a hard-to-debug problem ("mkdir: no such file or dir", no metadata, etc). R=rsc CC=golang-dev http://codereview.appspot.com/4172060 Committer: Russ Cox <rsc@golang.org>
* codereview: use cmd.communicate.Yasuhiro Matsumoto2011-02-081-4/+2
| | | | | | | | R=golang-dev, rsc CC=golang-dev http://codereview.appspot.com/4145046 Committer: Russ Cox <rsc@golang.org>
* codereview: fix hgpatch on windowsYasuhiro Matsumoto2011-02-021-4/+3
| | | | | | | | R=rsc CC=golang-dev http://codereview.appspot.com/3989059 Committer: Russ Cox <rsc@golang.org>
* codereview: record repository, base revisionRuss Cox2011-02-021-10/+28
| | | | | | | | | Include repository URL in initial mail. Record repository and base revision in patch description. R=r CC=golang-dev http://codereview.appspot.com/4126052
* codereview: more ascii vs unicode nonsenseRuss Cox2011-02-011-2/+35
| | | | | | R=r CC=golang-dev http://codereview.appspot.com/4124047
* codereview: fix windowsHector Chu2011-01-241-1/+1
| | | | | | | | | | | Uploading go files on Windows aborts with gofmt: exceptions.ValueError: close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr R=rsc, mattn, Joe Poirier CC=golang-dev http://codereview.appspot.com/4025046 Committer: Russ Cox <rsc@golang.org>
* codereview: handle file patterns betterRuss Cox2011-01-241-19/+137
| | | | | | | | | | | | | | | | | If a file pattern is given and matches files that look like they need to be hg added or hg removed, offer to do so. If a file pattern is given and matches files in another CL, warn. If a file pattern doesn't match anything, point that out. Vet first line of CL description. Fixes issue 972. R=adg, niemeyer CC=bradfitzgo, golang-dev http://codereview.appspot.com/4099042
* codereview: fix hg change on WindowsHector Chu2011-01-191-1/+1
| | | | | | | | | | hg change fails on Windows with 'No valid patches found in output from hg diff'. R=rsc CC=golang-dev http://codereview.appspot.com/4006043 Committer: Russ Cox <rsc@golang.org>
* codereview: don't mail change lists with no filesRyan Hitchman2011-01-191-2/+6
| | | | | | | | R=rsc CC=golang-dev http://codereview.appspot.com/3561041 Committer: Russ Cox <rsc@golang.org>
View Lorry Controller Status