| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The patch makes the compile user an ordinary package-local
symbol for the name of embedded fields of builtin type.
This is incompatible with the fix delivered for issue 2687
(revision 3c060add43fb) but fixes it in a different way, because
the explicit symbol on the field makes the typechecker able to
find it in lookdot.
Fixes issue 3552.
R=lvd, rsc, daniel.morsing
CC=golang-dev
https://codereview.appspot.com/6866047
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Today, if run.go doesn't understand a test header line it just ignores
the test, making it too easy to write or edit tests that are not actually
being run.
- expand errorcheck to accept flags, so that bounds.go and escape*.go can run.
- create a whitelist of skippable tests in run.go; skipping others is an error.
- mark all skipped tests at top of file.
Update issue 4139.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6549054
|
|
|
|
|
|
|
|
|
| |
Fixes issue 3909.
Fixes issue 3910.
R=rsc, nigeltao
CC=golang-dev
http://codereview.appspot.com/6442114
|
|
|
|
|
|
|
|
|
|
|
| |
There's no need for the 16-bit arithmetic here,
and it tickles a long-standing compiler bug.
Fix the exp code not to use 16-bit math and
create an explicit test for the compiler bug.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/6256048
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/6128051
|
|
|
|
|
|
|
|
| |
Fixes issue 3146.
R=ken2
CC=golang-dev
http://codereview.appspot.com/5756074
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5695083
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Preserve test.
changeset: 11593:f1deaf35e1d1
user: Luuk van Dijk <lvd@golang.org>
date: Tue Jan 17 10:00:57 2012 +0100
summary: gc: fix infinite recursion for embedded interfaces
This is causing 'interface type loop' errors during compilation
of a complex program. I don't understand what's happening
well enough to boil it down to a simple test case, but undoing
this change fixes the problem.
The change being undone is fixing a corner case (uses of
pointer to interface in an interface definition) that basically
only comes up in erroneous Go programs. Let's not try to
fix this again until after Go 1.
Unfixes issue 1909.
TBR=lvd
CC=golang-dev
http://codereview.appspot.com/5555063
|
|
|
|
|
|
|
|
|
| |
Now that Luuk's qualified exporting code
is in, fixing this bug is trivial.
R=ken2
CC=golang-dev
http://codereview.appspot.com/5479048
|
|
|
|
|
|
|
|
|
|
|
| |
The spec says that all methods are inherited from an anonymous
field. There is no exception for non-exported methods.
This is related to issue 1536.
R=rsc
CC=golang-dev
http://codereview.appspot.com/5012043
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
The spec was adjusted in commit df410d6a4842 to allow the
implicit assignment of strutures with unexported fields in
method receivers. This change updates the compiler.
Also moved bug322 into fixedbugs and updated golden.out
to reflect the removal of the last known bug.
Fixes issue 1402.
R=golang-dev, gri, rsc
CC=golang-dev
http://codereview.appspot.com/4526069
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
go/types: update for export data format change
reflect: require package qualifiers to match during interface check
runtime: require package qualifiers to match during interface check
test: fixed bug324, adapt to be silent
Fixes issue 1550.
Issue 1536 remains open.
R=gri, ken2, r
CC=golang-dev
http://codereview.appspot.com/4442071
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Failing at compile time requires that for each conversion
between two interface types the compiler compare the sets of
unexported methods to see if they come from different
packages. Since this test will fail approximately never on
real code, and since it can't catch all cases of the problem,
I don't think it's worth testing in the compiler. This CL
changes this test to look for a run-time panic rather than a
compile-time error.
R=gri, rsc1, iant2, rsc
CC=golang-dev
http://codereview.appspot.com/4332041
|
|
|
|
|
|
| |
R=gri, rsc1
CC=golang-dev
http://codereview.appspot.com/4328041
|
|
|
|
|
|
|
|
|
| |
Also: renamed fixedbugs/bug322.go to fixedbugs/bug323.go
because we already have a bugs/bug322.go and bug322.dir.
R=rsc
CC=golang-dev
http://codereview.appspot.com/4219044
|
|
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/4079063
Committer: Robert Griesemer <gri@golang.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
cc: same
runtime: test cc alignment (required moving #define of offsetof to runtime.h)
fix bug260
Fixes issue 482.
Fixes issue 609.
R=ken2, r
CC=golang-dev
http://codereview.appspot.com/3563042
|
|
|
|
|
|
| |
R=iant
CC=golang-dev, ken2
http://codereview.appspot.com/2182043
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/2127045
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/1731057
|
|
|
|
|
|
|
|
|
| |
( This CL is dependent on acceptance of
http://codereview.appspot.com/1913041/show )
R=go-dev
CC=golang-dev
http://codereview.appspot.com/1860045
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1846051
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/1742044
|
|
|
|
|
|
|
|
|
| |
Fixes issue 849.
Fixes issue 920.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1841042
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1644042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
|
|
|
|
| |
R=gri
CC=golang-dev
http://codereview.appspot.com/1616041
|
|
|
|
|
|
| |
R=gri
CC=golang-dev
http://codereview.appspot.com/1612041
|
|
|
|
|
|
|
|
| |
*T2 implements I2, but T2 does not.
R=gri
CC=golang-dev
http://codereview.appspot.com/1613041
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/1473042
|
|
|
|
|
|
| |
R=r, iant
CC=golang-dev
http://codereview.appspot.com/1433042
|
|
|
|
|
|
| |
R=rsc, r, iant
CC=golang-dev
http://codereview.appspot.com/1465041
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/1220046
|
|
|
|
|
|
|
|
|
|
| |
- accepted by gccgo, gofmt
- some not accepted by 6g
- spec revision forthcoming
R=rsc
CC=golang-dev
http://codereview.appspot.com/1279041
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/1224044
|
|
|
|
|
|
| |
R=r, ken2
CC=golang-dev
http://codereview.appspot.com/1260041
|
|
|
|
|
|
| |
R=r, iant
CC=golang-dev
http://codereview.appspot.com/1195042
|
|
|
|
|
|
|
|
| |
Fixes issue 692.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1092041
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/1067042
|
|
|
|
|
|
|
|
| |
where index is a composite literal
R=rsc
CC=golang-dev
http://codereview.appspot.com/961044
|
|
|
|
|
|
|
|
| |
Fixes issue 700.
R=ken2
CC=golang-dev
http://codereview.appspot.com/839041
|
|
|
|
|
|
|
|
| |
( http://code.google.com/p/go/issues/detail?id=700 )
R=r
CC=golang-dev
http://codereview.appspot.com/827042
|
|
|
|
|
|
| |
R=rsc, gri
CC=golang-dev
http://codereview.appspot.com/762041
|
|
|
|
|
|
| |
R=r
CC=golang-dev
http://codereview.appspot.com/715042
|
|
|
|
|
|
|
|
|
| |
Passing an argument to bug260 will indicate which alignments
are wrong.
R=r
CC=golang-dev
http://codereview.appspot.com/231042
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/237041
|
|
|
|
|
|
|
|
| |
Fixes issue 287.
R=ken2
CC=golang-dev
http://codereview.appspot.com/215048
|
|
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue 582.
Update issue 287
Status: Accepted
Bug fix was too intrusive; undo and reopen issue.
R=ken2
CC=golang-dev
http://codereview.appspot.com/209044
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/198057
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/198053
|