| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
Fixes issue 6606.
LGTM=rsc
R=rsc
CC=golang-codereviews, gri
https://codereview.appspot.com/156210044
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue 5691.
R=golang-dev, bradfitz, daniel.morsing, rsc
CC=golang-dev
https://codereview.appspot.com/10255047
Committer: Rob Pike <r@golang.org>
|
|
|
|
|
|
|
|
|
|
|
| |
The other tests either need a complex procedure
or are architecture- or OS-dependent.
Update issue 4139.
R=golang-dev, daniel.morsing, iant
CC=golang-dev
http://codereview.appspot.com/6618062
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Today, if run.go doesn't understand a test header line it just ignores
the test, making it too easy to write or edit tests that are not actually
being run.
- expand errorcheck to accept flags, so that bounds.go and escape*.go can run.
- create a whitelist of skippable tests in run.go; skipping others is an error.
- mark all skipped tests at top of file.
Update issue 4139.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6549054
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accomplished by synchronizing the formatting of conversion errors between typecheck.c and subr.c
Fixes issue 3984.
R=golang-dev, remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6500064
Committer: Russ Cox <rsc@golang.org>
|
|
|
|
|
|
|
|
|
|
| |
Fixes issue 3465.
R=golang-dev, rsc, remyoudompheng, iant
CC=golang-dev
http://codereview.appspot.com/6448097
Committer: Ian Lance Taylor <iant@golang.org>
|
|
|
|
|
|
|
|
| |
Introduce a new skip cmd.
R=golang-dev, bradfitz, iant, iant
CC=golang-dev
http://codereview.appspot.com/5868048
|
|
|
|
|
|
|
|
| |
Most already had comments (yay); adjusted for consistency.
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5676102
|
|
|
|
|
|
|
|
|
|
|
| |
Apply sed with:
1s,^// $G $D/$F.go && $L $F.$A && ./$A.out || echo.*,// run,
1s,^// $G $D/$F.go || echo.*,// compile,
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5656099
|
|
|
|
|
|
|
|
|
|
|
| |
X ,s;^// \$G (\$D/)?\$F\.go *$;// compile;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A *$;// build;g
X ,s;^// \$G (\$D/)?\$F\.go && \$L \$F\.\$A && \./\$A\.out *$;// run;g
X ,s;^// errchk \$G( -e)? (\$D/)?\$F\.go *$;// errorcheck;g
R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/5673079
|
|
|
|
|
|
|
|
| |
Part of issue 2833, but works fine with current test runner.
R=golang-dev, rsc
CC=golang-dev
http://codereview.appspot.com/5606056
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/5555066
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
To allow these types as map keys, we must fill in
equal and hash functions in their algorithm tables.
Structs or arrays that are "just memory", like [2]int,
can and do continue to use the AMEM algorithm.
Structs or arrays that contain special values like
strings or interface values use generated functions
for both equal and hash.
The runtime helper func runtime.equal(t, x, y) bool handles
the general equality case for x == y and calls out to
the equal implementation in the algorithm table.
For short values (<= 4 struct fields or array elements),
the sequence of elementwise comparisons is inlined
instead of calling runtime.equal.
R=ken, mpimenov
CC=golang-dev
http://codereview.appspot.com/5451105
|
|
|
|
|
|
|
|
| |
Missed when I removed direct map/func equality.
R=ken2
CC=golang-dev
http://codereview.appspot.com/5452052
|
|
|
|
|
|
|
|
|
| |
Had been allowing it for use by fmt, but it is too hard to lock down.
Fix other packages not to depend on it.
R=r, r
CC=golang-dev
http://codereview.appspot.com/5266054
|
|
|
|
|
|
|
|
| |
Add copyright notice to nilptr.go.
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5139048
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
bug363.go:13:12: error: invalid context-determined non-integer type for shift operand
bug363.go:16:12: error: invalid context-determined non-integer type for shift operand
pointer.go:34:6: error: incompatible type in initialization (pointer to interface type has no methods)
pointer.go:36:6: error: incompatible type in initialization
method2.go:15:1: error: invalid pointer or interface receiver type
method2.go:16:1: error: invalid pointer or interface receiver type
method2.go:21:1: error: invalid pointer or interface receiver type
method2.go:22:1: error: invalid pointer or interface receiver type
method2.go:28:15: error: type ?*Val? has no method ?val?
method2.go:33:11: error: reference to undefined field or method ?val?
shift1.go:19:16: error: invalid context-determined non-integer type for shift operand
shift1.go:24:19: error: invalid context-determined non-integer type for shift operand
shift1.go:25:17: error: invalid context-determined non-integer type for shift operand
shift1.go:18:18: error: shift of non-integer operand
shift1.go:26:13: error: floating point constant truncated to integer
shift1.go:33:15: error: integer constant overflow
shift1.go:34:15: error: integer constant overflow
shift1.go:35:17: error: integer constant overflow
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/5081051
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
// ERROR "pattern1" "pattern2"
means that there has to be one or more
lines matching pattern1 and then excluding
those, there have to be one or more lines
matching pattern2. So if you expect two
different error messages from a particular
line, writing two separate patterns checks
that both errors are produced.
Also, errchk now flags lines that produce
more errors than expected. Before, as long as
at least one error matched the pattern, all the
others were ignored.
Revise tests to expect or silence these
additional errors.
R=lvd, r, iant
CC=golang-dev
http://codereview.appspot.com/4869044
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4435067
|
|
|
|
|
|
| |
R=ken2
CC=golang-dev
http://codereview.appspot.com/4444056
|
|
|
|
|
|
| |
R=golang-dev, r
CC=golang-dev
http://codereview.appspot.com/4353043
|
|
|
|
|
|
| |
R=rsc
CC=golang-dev
http://codereview.appspot.com/4271086
|
|
|
|
|
|
|
|
|
|
|
| |
also:
cmplx -> complex
float64(1.0) -> 1.0
float64(1) -> 1.0
R=gri, r, gri1, r2
CC=golang-dev
http://codereview.appspot.com/3991043
|
|
|
|
|
|
|
|
| |
Implies no embedding of pointer to interface value either.
R=gri, iant, ken2, r, r2
CC=golang-dev
http://codereview.appspot.com/2289041
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicit.go:36:4: error: incompatible types in assignment (need explicit conversion)
explicit.go:41:4: error: incompatible types in assignment (type has no methods)
explicit.go:42:4: error: incompatible types in assignment (need explicit conversion)
explicit.go:45:5: error: incompatible types in assignment (need explicit conversion; missing method ?N?)
explicit.go:48:9: error: invalid type conversion (need explicit conversion; missing method ?N?)
explicit.go:51:4: error: incompatible types in assignment
explicit.go:51:7: error: invalid type conversion (need explicit conversion)
explicit.go:57:10: error: impossible type assertion: type does not implement interface (type has no methods)
explicit.go:62:10: error: impossible type assertion: type does not implement interface (incompatible type for method ?M? (different number of parameters))
explicit.go:67:5: error: incompatible type in initialization (type has no methods)
explicit.go:68:5: error: incompatible type in initialization (incompatible type for method ?M? (different number of parameters))
explicit.go:70:11: error: invalid type conversion (type has no methods)
explicit.go:71:11: error: invalid type conversion (incompatible type for method ?M? (different number of parameters))
R=rsc
CC=golang-dev
http://codereview.appspot.com/2139044
|
|
|
|
|
|
|
|
| |
The ken directory is untouched so we have some examples with explicit semis.
R=gri
CC=golang-dev
http://codereview.appspot.com/2157041
|
|
|
|
|
|
|
|
|
|
|
|
| |
* disallow surrogate pair runes.
* diagnose impossible type assertions
* eliminate another static buffer.
* do not overflow lexbuf.
* add -u flag to disable package unsafe.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1619042
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
* Code for assignment, conversions now mirrors spec.
* Changed some snprint -> smprint.
* Renamed runtime functions to separate
interface conversions from type assertions:
convT2I, assertI2T, etc.
* Correct checking of \U sequences.
Fixes issue 840.
Fixes issue 830.
Fixes issue 778.
R=ken2
CC=golang-dev
http://codereview.appspot.com/1303042
|
|
|
|
|
|
|
|
|
|
|
|
| |
note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.
stop on error in doc/progs/run
R=r
CC=golang-dev
http://codereview.appspot.com/850041
|
|
|
|
|
|
|
|
|
| |
in the tests, println+panic.
gofmt some tests too.
R=rsc
CC=golang-dev
http://codereview.appspot.com/741041
|
|
|
|
|
|
|
| |
versions of static checks in receiver1.go
R=r
http://codereview.appspot.com/155045
|
|
|
|
|
|
|
| |
defs from embed1 and gotest
R=rsc
http://go/go-review/1014009
|
|
|
|
|
|
| |
R=ken
OCL=35917
CL=35917
|
|
|
|
|
|
|
|
|
|
| |
* bug211
* embedded interfaces with lowercase methods
* var _ = f() at top level
R=ken
OCL=35898
CL=35898
|
|
|
|
|
|
|
| |
R=rsc
DELTA=2 (2 added, 0 deleted, 0 changed)
OCL=35874
CL=35880
|
|
|
|
|
|
|
|
|
| |
also template/template.go, missed last time.
R=r
DELTA=116 (61 added, 10 deleted, 45 changed)
OCL=34620
CL=34622
|
|
|
|
|
|
| |
R=rsc
OCL=33382
CL=33391
|
|
|
|
|
|
|
| |
R=r
DELTA=163 (1 added, 149 deleted, 13 changed)
OCL=33106
CL=33111
|
|
|
|
|
|
|
|
|
| |
mostly removing forward declarations.
R=r
DELTA=138 (2 added, 127 deleted, 9 changed)
OCL=33068
CL=33099
|
|
|
|
|
|
|
|
|
| |
typecheck.c is now responsible for all type checking
except for assignment and function argument "..."
R=ken
OCL=32661
CL=32667
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
explicit.go:21:5: error: incompatible types in assignment (need explicit conversion)
explicit.go:26:5: error: incompatible types in assignment (type has no methods)
explicit.go:27:5: error: incompatible types in assignment (need explicit conversion)
explicit.go:30:6: error: incompatible types in assignment (need explicit conversion; missing method ?N?)
explicit.go:33:7: error: invalid type conversion (need explicit conversion; missing method ?N?)
explicit.go:36:5: error: incompatible types in assignment
R=rsc
DELTA=1 (0 added, 0 deleted, 1 changed)
OCL=31805
CL=31807
|
|
|
|
|
|
|
| |
R=r
DELTA=12 (0 added, 0 deleted, 12 changed)
OCL=31240
CL=31290
|
|
|
|
|
|
|
|
| |
when implicit assignment would have been okay.
R=ken
OCL=31225
CL=31227
|
|
|
|
|
|
|
| |
R=r
DELTA=21 (21 added, 0 deleted, 0 changed)
OCL=29212
CL=29249
|
|
move interface tests to subdirectory.
R=r
DELTA=1632 (827 added, 804 deleted, 1 changed)
OCL=29181
CL=29191
|