summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSam Thursfield <sam@afuera.me.uk>2017-04-14 13:02:35 +0100
committerSam Thursfield <sam@afuera.me.uk>2017-04-15 12:38:28 +0100
commit85b1d70b93211415d975deff6050f1401743e72d (patch)
treeb2215363afa7135eb4ab50b8cfc32c9ac0607d4e
parenta355c02a047795852e2bc673e1a48af9e43b2037 (diff)
downloadgobject-introspection-85b1d70b93211415d975deff6050f1401743e72d.tar.gz
Fix 'Bad file descriptor' error when checking libtool version
Running g-ir-scanner on Fedora 25 (libtool 2.4.6) produces the following message on stderr, twice: /usr/bin/libtool: line 2460: printf: write error: Bad file descriptor This is because we were redirecting stdout to /dev/null incorrectly -- we were opening /dev/null for reading rather than for writing. https://bugzilla.gnome.org/show_bug.cgi?id=781312
-rw-r--r--giscanner/utils.py2
1 files changed, 1 insertions, 1 deletions
diff --git a/giscanner/utils.py b/giscanner/utils.py
index aff5393a..da848d52 100644
--- a/giscanner/utils.py
+++ b/giscanner/utils.py
@@ -159,7 +159,7 @@ def get_libtool_command(options):
libtool_cmd = 'glibtool'
try:
subprocess.check_call([libtool_cmd, '--version'],
- stdout=open(os.devnull))
+ stdout=open('/dev/null', 'w'))
except (subprocess.CalledProcessError, OSError):
# If libtool's not installed, assume we don't need it
return None