summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAbseil Team <absl-team@google.com>2023-03-08 15:09:58 -0800
committerCopybara-Service <copybara-worker@google.com>2023-03-08 15:10:45 -0800
commit48a1b110583dd55e5076952b2acd772d9aaf6372 (patch)
tree3a1723240e79017cb3ab3e2158940e6c19cf0489
parent82a570453ccd9a9ca8a75b82aa1850b74ce27337 (diff)
downloadgoogletest-git-48a1b110583dd55e5076952b2acd772d9aaf6372.tar.gz
Add a comment to clarify Fuchsia process launcher requirement.
PiperOrigin-RevId: 515154129 Change-Id: I3dd9e912e160d09d1f74a467336212701d4e1b7d
-rw-r--r--googletest/src/gtest-death-test.cc5
1 files changed, 5 insertions, 0 deletions
diff --git a/googletest/src/gtest-death-test.cc b/googletest/src/gtest-death-test.cc
index 649b17b5..1bf2f312 100644
--- a/googletest/src/gtest-death-test.cc
+++ b/googletest/src/gtest-death-test.cc
@@ -1024,6 +1024,11 @@ DeathTest::TestRole FuchsiaDeathTest::AssumeRole() {
GTEST_DEATH_TEST_CHECK_(status == ZX_OK);
// Spawn the child process.
+ // Note: The test component must have `fuchsia.process.Launcher` declared
+ // in its manifest. (Fuchsia integration tests require creating a
+ // "Fuchsia Test Component" which contains a "Fuchsia Component Manifest")
+ // Launching processes is a privileged operation in Fuschia, and the
+ // declaration indicates that the ability is required for the component.
std::unique_ptr<char*[]> argv = CreateArgvFromArgs(args);
status = fdio_spawn_etc(child_job, FDIO_SPAWN_CLONE_ALL, argv[0], argv.get(),
nullptr, 2, spawn_actions,