diff options
| author | Tom Hughes <tomhughes@google.com> | 2023-02-02 09:31:10 -0800 |
|---|---|---|
| committer | Copybara-Service <copybara-worker@google.com> | 2023-02-02 09:31:44 -0800 |
| commit | deaf5615f18dd3b051006ba7326e2a976f5dff46 (patch) | |
| tree | 5b9e60a5421cfbbce158adc605c44439ecee19e0 /googletest/src | |
| parent | 4f7c63d991824b8034a81a0dd91f8b90a20d7806 (diff) | |
| download | googletest-git-deaf5615f18dd3b051006ba7326e2a976f5dff46.tar.gz | |
Fix -Wsign-conversion warnings
googletest/test/gtest_xml_outfile2_test_.cc:48:39:
warning: implicit conversion turns floating-point number into integer:
'float' to 'int64_t' (aka 'long') [-Wfloat-conversion]
RecordProperty("TestFloatProperty", float_prop);
~~~~~~~~~~~~~~ ^~~~~~~~~~
googletest/test/gtest_xml_outfile2_test_.cc:51:40:
warning: implicit conversion turns floating-point number into integer:
'double' to 'int64_t' (aka 'long') [-Wfloat-conversion]
RecordProperty("TestDoubleProperty", double_prop);
~~~~~~~~~~~~~~ ^~~~~~~~~~~
googletest/test/gtest_xml_outfile2_test_.cc:57:39:
warning: implicit conversion changes signedness:
'size_t' (aka 'unsigned long') to 'int64_t' (aka 'long') [-Wsign-conversion]
RecordProperty("TestSizetProperty", size_t_prop);
~~~~~~~~~~~~~~ ^~~~~~~~~~~
PiperOrigin-RevId: 506644143
Change-Id: I9c2cd5f52daebe25e73bb97f696687797ed2cabf
Diffstat (limited to 'googletest/src')
| -rw-r--r-- | googletest/src/gtest.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/googletest/src/gtest.cc b/googletest/src/gtest.cc index b9289439..f79f915f 100644 --- a/googletest/src/gtest.cc +++ b/googletest/src/gtest.cc @@ -2459,11 +2459,6 @@ void Test::TearDown() {} void Test::RecordProperty(const std::string& key, const std::string& value) { UnitTest::GetInstance()->RecordProperty(key, value); } -// We do not define a customary serialization except for integers, -// but other values could be logged in this way. -void Test::RecordProperty(const std::string& key, int64_t value) { - RecordProperty(key, (Message() << value).GetString()); -} namespace internal { |