summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric S. Raymond <esr@thyrsus.com>2017-09-06 20:47:40 -0400
committerEric S. Raymond <esr@thyrsus.com>2017-09-06 20:47:40 -0400
commitd17e6edd5d13490da6fc3edf8e032801d8380b50 (patch)
tree408e002837441a737d50b8c7bcbffbf14b6f86b1
parent519bd230ac97a9114d307342108614b3c4f61f3c (diff)
downloadgpsd-d17e6edd5d13490da6fc3edf8e032801d8380b50.tar.gz
Revert a previous change to suppress cppcheck warning...
...that breaks the build on some platforms.
-rw-r--r--driver_garmin.c3
-rw-r--r--driver_garmin_txt.c1
2 files changed, 3 insertions, 1 deletions
diff --git a/driver_garmin.c b/driver_garmin.c
index 46d3d0ad..3b17a84a 100644
--- a/driver_garmin.c
+++ b/driver_garmin.c
@@ -236,7 +236,8 @@ typedef struct __attribute__((__packed__))
union
{
//int8_t chars[MAX_BUFFER_SIZE];
- //uint8_t uchars[MAX_BUFFER_SIZE];
+ // cppcheck-suppress unusedStructMember
+ uint8_t uchars[MAX_BUFFER_SIZE];
cpo_pvt_data pvt;
cpo_sat_data sats;
} mData;
diff --git a/driver_garmin_txt.c b/driver_garmin_txt.c
index c14c5161..e8e878a2 100644
--- a/driver_garmin_txt.c
+++ b/driver_garmin_txt.c
@@ -172,6 +172,7 @@ static int gar_decode(const struct gps_context_t *context,
}
/* second character in prefix is flag for negative number */
if (preflen >= 2) {
+ // cppcheck-suppress arrayIndexOutOfBounds
if (buf[0] == prefix[1]) {
sign = -1.0;
break;