summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric S. Raymond <esr@thyrsus.com>2010-05-12 18:45:28 -0400
committerEric S. Raymond <esr@thyrsus.com>2010-05-12 18:45:28 -0400
commit7c506d8dc964781e59c1b9b5d6e43fb90e83b722 (patch)
tree34d16efa720aea2c01980e972ff29ad77a3c3aed
parent068889d5a3950b1bacdfdf1f06dd8e4cd3b3f7ea (diff)
downloadgpsd-7c506d8dc964781e59c1b9b5d6e43fb90e83b722.tar.gz
XXX -> FIX-ME: Avoids false matches with autoconf cruft.
So we can grep for things that need to be cleaned up without a lot of noise. All regression tests pass.
-rw-r--r--driver_italk.h2
-rw-r--r--driver_oncore.c2
-rw-r--r--driver_proto.c6
-rw-r--r--driver_superstar2.c3
-rw-r--r--driver_tsip.c4
-rw-r--r--driver_ubx.c2
-rw-r--r--gpsd.h-tail2
-rw-r--r--isgps.c1
-rw-r--r--lcdgps.c2
9 files changed, 11 insertions, 13 deletions
diff --git a/driver_italk.h b/driver_italk.h
index df88fe0c..b4dc7633 100644
--- a/driver_italk.h
+++ b/driver_italk.h
@@ -24,7 +24,7 @@
#define NODE_HOST 0x40 /* Software on your computer */
#define NODE_GPSWB 0x60 /* GPSWorkbench seems to be HOST|ITRAX */
-/* XXX These defines will likely be replaced by an enum
+/* FIX-ME: These defines will likely be replaced by an enum
* once I map every message to the task that sent it.
*/
/* System controller on the receiver */
diff --git a/driver_oncore.c b/driver_oncore.c
index 5c494712..bf25d515 100644
--- a/driver_oncore.c
+++ b/driver_oncore.c
@@ -372,7 +372,7 @@ gps_mask_t oncore_dispatch(struct gps_device_t * session, unsigned char *buf,
return oncore_msg_pps_delay(session, buf, len);
default:
- /* XXX This gets noisy in a hurry. Change once your driver works */
+ /* FIX-ME: This gets noisy in a hurry. Change once your driver works */
gpsd_report(LOG_WARN, "unknown packet id @@%c%c length %zd: %s\n",
type >> 8, type & 0xff, len, gpsd_hexdump_wrapper(buf,
len,
diff --git a/driver_proto.c b/driver_proto.c
index 1189e891..b0a44a27 100644
--- a/driver_proto.c
+++ b/driver_proto.c
@@ -257,8 +257,8 @@ gps_mask_t _proto__dispatch(struct gps_device_t *session, unsigned char *buf, si
type, len, gpsd_hexdump_wrapper(buf, len, LOG_WARN));
/*
- * XXX The tag field is only 8 bytes; be careful you do not overflow.
- * XXX Using an abbreviation (eg. "italk" -> "itk") may be useful.
+ * The tag field is only 8 bytes; be careful you do not overflow.
+ * Using an abbreviation (eg. "italk" -> "itk") may be useful.
*/
(void)snprintf(session->gpsdata.tag, sizeof(session->gpsdata.tag),
"_PROTO_%02x", type);
@@ -268,7 +268,7 @@ gps_mask_t _proto__dispatch(struct gps_device_t *session, unsigned char *buf, si
/* Deliver message to specific decoder based on message type */
default:
- /* XXX This gets noisy in a hurry. Change once your driver works */
+ /* This gets noisy in a hurry. Change once your driver works */
gpsd_report(LOG_WARN, "unknown packet id %d length %d: %s\n",
type, len, gpsd_hexdump_wrapper(buf, len, LOG_WARN));
return 0;
diff --git a/driver_superstar2.c b/driver_superstar2.c
index f50a15a1..5bd61791 100644
--- a/driver_superstar2.c
+++ b/driver_superstar2.c
@@ -376,7 +376,7 @@ superstar2_write(struct gps_device_t *session, char *msg, size_t msglen)
for (i = 0; i < (ssize_t) (msglen - 2); i++)
c += (unsigned short)msg[i];
c += 0x100;
- // c = htons(c); // XXX is this needed on big-endian machines?
+ // c = htons(c); // FIX-ME: is this needed on big-endian machines?
(void)memcpy(msg + (int)msg[3] + 4, &c, 2);
gpsd_report(LOG_IO, "writing superstar2 control type %d len %zu:%s\n",
(int)msg[1] & 0x7f, msglen,
@@ -422,7 +422,6 @@ superstar2_dispatch(struct gps_device_t * session, unsigned char *buf,
return superstar2_msg_ephemeris(session, buf, len);
default:
- /* XXX This gets noisy in a hurry. */
gpsd_report(LOG_WARN,
"unknown superstar2 packet id 0x%02x length %zd: %s\n",
type, len, gpsd_hexdump_wrapper(buf, len, LOG_WARN));
diff --git a/driver_tsip.c b/driver_tsip.c
index 0b1bbf17..648b5f0f 100644
--- a/driver_tsip.c
+++ b/driver_tsip.c
@@ -600,7 +600,7 @@ static gps_mask_t tsip_analyze(struct gps_device_t *session)
break;
case 0x20: /* Last Fix with Extra Information (binary fixed point) */
- /* XXX CSK sez "why does my Lassen iQ output oversize packets?" */
+ /* CSK sez "why does my Lassen iQ output oversize packets?" */
if ((len != 56) && (len != 64))
break;
s1 = getbesw(buf, 2); /* east velocity */
@@ -679,7 +679,7 @@ static gps_mask_t tsip_analyze(struct gps_device_t *session)
break;
case 0x23: /* Compact Super Packet */
session->driver.tsip.req_compact = 0;
- /* XXX CSK sez "i don't trust this to not be oversized either." */
+ /* CSK sez "i don't trust this to not be oversized either." */
if (len < 29)
break;
ul1 = getbeul(buf, 1); /* time */
diff --git a/driver_ubx.c b/driver_ubx.c
index 93a14be9..f9324177 100644
--- a/driver_ubx.c
+++ b/driver_ubx.c
@@ -106,7 +106,7 @@ ubx_msg_nav_sol(struct gps_device_t *session, unsigned char *buf,
break;
case UBX_MODE_2D:
case UBX_MODE_DR: /* consider this too as 2D */
- case UBX_MODE_GPSDR: /* XXX DR-aided GPS may be valid 3D */
+ case UBX_MODE_GPSDR: /* FIX-ME: DR-aided GPS may be valid 3D */
session->newdata.mode = MODE_2D;
break;
default:
diff --git a/gpsd.h-tail b/gpsd.h-tail
index 3421497f..98ebf15c 100644
--- a/gpsd.h-tail
+++ b/gpsd.h-tail
@@ -634,7 +634,7 @@ extern float roundf(float x);
#define NITEMS(x) (int)(sizeof(x)/sizeof(x[0]))
/* OpenBSD and FreeBSD and Cygwin don't seem to have NAN, NetBSD does, others? */
-/* XXX test for this in configure? */
+/* FIX-ME: test for this in configure? */
#if defined(__OpenBSD__) || defined(__FreeBSD__) || defined(__CYGWIN__)
#ifndef NAN
#define NAN (0.0/0.0)
diff --git a/isgps.c b/isgps.c
index c29a7c36..db13d430 100644
--- a/isgps.c
+++ b/isgps.c
@@ -219,7 +219,6 @@ enum isgpsstat_t isgps_decode(struct gps_packet_t *session,
gpsd_report(ISGPS_ERRLEVEL_BASE + 1,
"ISGPS preamble ok, parity ok -- locked\n");
session->isgps.locked = true;
- /* session->isgps.curr_offset; XXX - testing */
break;
}
gpsd_report(ISGPS_ERRLEVEL_BASE + 1,
diff --git a/lcdgps.c b/lcdgps.c
index b784184a..1a7fbde5 100644
--- a/lcdgps.c
+++ b/lcdgps.c
@@ -247,7 +247,7 @@ int send_lcd(char *buf) {
res=sockreadline(sd,rcvbuf,255);
/* null-terminate the string before printing */
- /* rcvbuf[res-1]=0; XXX not using this at the moment... */
+ /* rcvbuf[res-1]=0; FIX-ME: not using this at the moment... */
/* return the result */
return(res);