diff options
author | Eric S. Raymond <esr@thyrsus.com> | 2013-09-17 08:02:43 -0400 |
---|---|---|
committer | Eric S. Raymond <esr@thyrsus.com> | 2013-09-17 08:02:43 -0400 |
commit | a34118b0a18820dc7d034dd04a0108c77ec12326 (patch) | |
tree | 528052d8b2f437a8ededa2f66f0a93d250b50670 | |
parent | 5773220c46e95b57a8c206f1621dd5139896182e (diff) | |
download | gpsd-a34118b0a18820dc7d034dd04a0108c77ec12326.tar.gz |
More cppcheck cleanup.
-rw-r--r-- | driver_garmin.c | 1 | ||||
-rw-r--r-- | driver_geostar.c | 1 | ||||
-rw-r--r-- | driver_italk.c | 1 | ||||
-rw-r--r-- | libgps_core.c | 1 | ||||
-rw-r--r-- | netlib.c | 1 | ||||
-rw-r--r-- | ntpshm.c | 3 |
6 files changed, 5 insertions, 3 deletions
diff --git a/driver_garmin.c b/driver_garmin.c index 3eac2b1f..7e4f82f3 100644 --- a/driver_garmin.c +++ b/driver_garmin.c @@ -817,7 +817,6 @@ static void Build_Send_SER_Packet(struct gps_device_t *session, * libudev: http://www.kernel.org/pub/linux/utils/kernel/hotplug/libudev/ */ /*@-compdef -usedef -nullpass@*/ -// cppcheck-suppress unusedFunction static bool is_usb_device(const char *path UNUSED, int vendor, int product) { // discover devices diff --git a/driver_geostar.c b/driver_geostar.c index e18e803b..eb8ba612 100644 --- a/driver_geostar.c +++ b/driver_geostar.c @@ -142,6 +142,7 @@ static gps_mask_t geostar_analyze(struct gps_device_t *session) /* put data part of message in buf */ memset(buf, 0, sizeof(buf)); + /* cppcheck-suppress redundantCopy */ memcpy(buf, session->packet.outbuffer, session->packet.outbuflen); buf2[len = 0] = '\0'; diff --git a/driver_italk.c b/driver_italk.c index b4214d0d..224a3392 100644 --- a/driver_italk.c +++ b/driver_italk.c @@ -390,7 +390,6 @@ static gps_mask_t italk_parse_input(struct gps_device_t *session) } #ifdef __future__ -// cppcheck-suppress unusedFunction static void italk_ping(struct gps_device_t *session) /* send a "ping". it may help us detect an itrax more quickly */ { diff --git a/libgps_core.c b/libgps_core.c index 5da71c4e..3ad9716d 100644 --- a/libgps_core.c +++ b/libgps_core.c @@ -179,6 +179,7 @@ int gps_stream(struct gps_data_t *gpsdata CONDITIONALLY_UNUSED, int status = -1; #ifdef SOCKET_EXPORT_ENABLE + /* cppcheck-suppress redundantAssignment */ status = gps_sock_stream(gpsdata, flags, d); #endif /* SOCKET_EXPORT_ENABLE */ @@ -33,6 +33,7 @@ socket_t netlib_connectsock(int af, const char *host, const char *service, socket_t s = -1; bool bind_me; + /* cppcheck-suppress redundantAssignment */ INVALIDATE_SOCKET(s); /*@-type@*/ ppe = getprotobyname(protocol); @@ -563,7 +563,8 @@ static /*@null@*/ void *gpsd_ppsmonitor(void *arg) double offset; int pulse; int leap; - int _pad; /* unused */ + /* cppcheck-suppress unusedStructMember */ + int _pad; int magic; /* must be SOCK_MAGIC */ } sample; /* chrony must be started first as chrony insists on creating the socket */ |