diff options
author | Eric S. Raymond <esr@thyrsus.com> | 2011-01-21 05:02:22 -0500 |
---|---|---|
committer | Eric S. Raymond <esr@thyrsus.com> | 2011-01-21 05:02:22 -0500 |
commit | a8fed05fc3760e05d809f3c612d7143261876f6b (patch) | |
tree | e492708e2bd161fd1201df61436a444fa9a92914 | |
parent | 45ec8b87531c5c967ab94dd531abe417dc912bf2 (diff) | |
download | gpsd-a8fed05fc3760e05d809f3c612d7143261876f6b.tar.gz |
Add some suitable warning comments.
-rw-r--r-- | driver_italk.c | 5 | ||||
-rw-r--r-- | driver_navcom.c | 5 | ||||
-rw-r--r-- | driver_tsip.c | 5 | ||||
-rw-r--r-- | driver_ubx.c | 5 | ||||
-rw-r--r-- | driver_zodiac.c | 6 |
5 files changed, 26 insertions, 0 deletions
diff --git a/driver_italk.c b/driver_italk.c index 816af154..62702d82 100644 --- a/driver_italk.c +++ b/driver_italk.c @@ -3,6 +3,11 @@ * BSD terms apply: see the file COPYING in the distribution root for details. * * Driver for the iTalk binary protocol used by FasTrax + * + * Week counters are not limited to 10 bits. It's unknown what + * the firmware is doing to disambiguate them, if anything; it might just + * be adding a fixed offset based on a hidden epoch value, in which case + * unhappy things will occur on the next rollover. */ #include <stdio.h> #include <stdbool.h> diff --git a/driver_navcom.c b/driver_navcom.c index 5f0b94e1..6801967b 100644 --- a/driver_navcom.c +++ b/driver_navcom.c @@ -26,6 +26,11 @@ * * By Diego Berge. Contact via web form at http://www.navlost.eu/contact * + * Week counters are not limited to 10 bits. It's unknown what + * the firmware is doing to disambiguate them, if anything; it might just + * be adding a fixed offset based on a hidden epoch value, in which case + * unhappy things will occur on the next rollover. + * * This file is Copyright (c) 2010 by the GPSD project * BSD terms apply: see the file COPYING in the distribution root for details. */ diff --git a/driver_tsip.c b/driver_tsip.c index 2fba94b9..7f754e1d 100644 --- a/driver_tsip.c +++ b/driver_tsip.c @@ -2,6 +2,11 @@ * Handle the Trimble TSIP packet format * by Rob Janssen, PE1CHL. * + * Week counters are not limited to 10 bits. It's unknown what + * the firmware is doing to disambiguate them, if anything; it might just + * be adding a fixed offset based on a hidden epoch value, in which case + * unhappy things will occur on the next rollover. + * * This file is Copyright (c) 2010 by the GPSD project * BSD terms apply: see the file COPYING in the distribution root for details. */ diff --git a/driver_ubx.c b/driver_ubx.c index 2ed6961f..fcbdd51f 100644 --- a/driver_ubx.c +++ b/driver_ubx.c @@ -1,6 +1,11 @@ /* * UBX driver * + * Week counters are not limited to 10 bits. It's unknown what + * the firmware is doing to disambiguate them, if anything; it might just + * be adding a fixed offset based on a hidden epoch value, in which case + * unhappy things will occur on the next rollover. + * * This file is Copyright (c) 2010 by the GPSD project * BSD terms apply: see the file COPYING in the distribution root for details. * diff --git a/driver_zodiac.c b/driver_zodiac.c index 7e61db17..7d54bf75 100644 --- a/driver_zodiac.c +++ b/driver_zodiac.c @@ -1,6 +1,11 @@ /* * Handle the Rockwell binary packet format supported by the old Zodiac chipset * + * Week counters are not limited to 10 bits. It's unknown what + * the firmware is doing to disambiguate them, if anything; it might just + * be adding a fixed offset based on a hidden epoch value, in which case + * unhappy things will occur on the next rollover. + * * This file is Copyright (c) 2010 by the GPSD project * BSD terms apply: see the file COPYING in the distribution root for details. */ @@ -221,6 +226,7 @@ static gps_mask_t handle1002(struct gps_device_t *session) int gps_seconds = getzlong(11); /* gps_nanoseconds = getzlong(13); */ /*@-charint@*/ + /* Note: this week counter is not limited to 10 bits. */ session->context->gps_week = (unsigned short)gps_week; session->gpsdata.satellites_used = 0; memset(session->gpsdata.used, 0, sizeof(session->gpsdata.used)); |