summaryrefslogtreecommitdiff
path: root/SConstruct
diff options
context:
space:
mode:
authorEric S. Raymond <esr@thyrsus.com>2013-11-15 10:40:55 -0500
committerEric S. Raymond <esr@thyrsus.com>2013-11-15 10:40:55 -0500
commit5d91b10b27a1b56bc7515aef14d5f67b8212ac94 (patch)
treef76c17245fb9239a0ae418ec6978176d8063ecd7 /SConstruct
parent7f23761c9ce26a5dddfddaf952fc81b590d474fc (diff)
downloadgpsd-5d91b10b27a1b56bc7515aef14d5f67b8212ac94.tar.gz
Give up on pychecker. pylint is better, add it to the audit sequence.
Diffstat (limited to 'SConstruct')
-rw-r--r--SConstruct11
1 files changed, 4 insertions, 7 deletions
diff --git a/SConstruct b/SConstruct
index a0ee10de..da306f58 100644
--- a/SConstruct
+++ b/SConstruct
@@ -1457,12 +1457,8 @@ Utility("cppcheck", ["gpsd.h", "packet_names.h"],
Utility("scan-build", ["gpsd.h", "packet_names.h"],
"scan-build scons")
-# Sanity-check Python code. TODO: add xgps for the complete set.
-Utility("pychecker", ["jsongen.py", "maskaudit.py", python_built_extensions],
- ['''for f in gpsprof gpscat gpsfake gegps; do ln -s $$f $$f.py; done; \
- pychecker --no-classattr --no-callinit jsongen.py leapsecond.py maskaudit.py gpsprof.py gpscat.py gpsfake.py gegps.py gps/*.py;
- for f in gpsprof gpscat gpsfake gegps; do rm $$f.py $$f.pyc; done'''])
-Utility("pylint", ["jsongen.py", "maskaudit.py", python_built_extensions],
+# Sanity-check Python code.
+pylint = Utility("pylint", ["jsongen.py", "maskaudit.py", python_built_extensions],
['''pylint --output-format=parseable --reports=n --include-ids=y --disable=F0001,C0103,C0111,C0301,C0302,C0322,C0324,C0323,C0321,R0201,R0801,R0902,R0903,R0904,R0911,R0912,R0913,R0914,R0915,R0924,W0201,W0401,W0403,W0141,W0142,W0603,W0614,W0621,E1101,E1102 jsongen.py leapsecond.py maskaudit.py gpsprof.py gpscat.py gpsfake.py gegps.py gps/*.py xgps'''])
# Check the documentation for bogons, too
@@ -1475,10 +1471,11 @@ Utility("deheader", generated_sources, [
'deheader -x cpp -x contrib -x gpspacket.c -x gpsclient.c -x monitor_proto.c -i gpsd_config.h -i gpsd.h -m "MORECFLAGS=\'-Werror -Wfatal-errors -DDEBUG -DPPS_ENABLE\' scons -Q"',
])
-# Perform all sanity checks.
+# Perform all local code-sanity checks (but not the Coverity scan).
audit = env.Alias('audit',
['splint',
'cppcheck',
+ 'pylint',
'xmllint',
'valgrind-audit',
])