The signed/unsigned char fix.

All regression tests pass on Raspbian “wheezy”.

Signed-off-by: Eric S. Raymond <esr@thyrsus.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/bits.c b/bits.c
index 31b332a7..f18797c7 100644
--- a/bits.c
+++ b/bits.c
@@ -17,7 +17,7 @@
 
 #include "bits.h"
 
-uint64_t ubits(char buf[], unsigned int start, unsigned int width, bool le)
+uint64_t ubits(unsigned char buf[], unsigned int start, unsigned int width, bool le)
 /* extract a (zero-origin) bitfield from the buffer as an unsigned big-endian uint64_t */
 {
     uint64_t fld = 0;
@@ -58,10 +58,10 @@ uint64_t ubits(char buf[], unsigned int start, unsigned int width, bool le)
     return fld;
 }
 
-int64_t sbits(char buf[], unsigned int start, unsigned int width, bool le)
+int64_t sbits(signed char buf[], unsigned int start, unsigned int width, bool le)
 /* extract a bitfield from the buffer as a signed big-endian long */
 {
-    uint64_t fld = ubits(buf, start, width, le);
+    uint64_t fld = ubits((unsigned char *)buf, start, width, le);
 
     /*@ +relaxtypes */
     if (fld & (1LL << (width - 1))) {