summaryrefslogtreecommitdiff
path: root/bsd_base64.c
diff options
context:
space:
mode:
authorEric S. Raymond <esr@thyrsus.com>2015-03-30 17:10:53 -0400
committerEric S. Raymond <esr@thyrsus.com>2015-03-30 17:10:53 -0400
commit28bf37132d86cc59320e21d843960d086cef664c (patch)
treebf085b5f89f1d1061b6a88ecc66c50721b13d86c /bsd_base64.c
parentecb7e1ff3ec73000918c56861c55258c2d4deada (diff)
downloadgpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error messages that were randomly and disturbingly variable across different environments - notably Raspbian and Gentoo splint gave nontrivially different results than Ubuntu 14.10 splint. And this was *not* due to Ubuntu patches! A pristine splint built from the 3.1.2 tarball on Ubuntu didn't match the Raspbian and Gentoo results either. But this has been coming for a while. Easy access to more modern static analyzers such as coverity, scan-build and cppcheck has been decreasing the utility of splint, which is unmaintained and somewhat buggy and not easy to use. Only file not cleaned is ppsthread.c, because Gary has been working on it during this cleanup. All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'bsd_base64.c')
-rw-r--r--bsd_base64.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/bsd_base64.c b/bsd_base64.c
index e3810ac6..a5301f0f 100644
--- a/bsd_base64.c
+++ b/bsd_base64.c
@@ -118,7 +118,6 @@ static const char Pad64 = '=';
characters followed by one "=" padding character.
*/
-/*@ +matchanyintegral -type @*/
int
b64_ntop(unsigned char const *src, size_t srclength, char *target,
size_t targsize)