Simplify the preparation of the build parameters.

Signed-off-by: Beat Bolli <dev@drbeat.li>
Signed-off-by: Jon Schlueter <jschlueter@redhat.com>

1 files changed, 4 insertions, 11 deletions

diff --git a/devtools/identify_failing_build_options.py b/devtools/identify_failing_build_options.py
index be8d4e75..e3238393 100755
--- a/devtools/identify_failing_build_options.py
+++ b/devtools/identify_failing_build_options.py
@@ -81,23 +81,16 @@ def main(starting_number_of_options=0):
     import itertools
     failed_configurations = []
 
+    static_params = [key + '=on' for key in always_on]
+    static_params += [key + '=off' for key in always_off]
+
     for i in range(starting_number_of_options, len(knobs)):
         jj = itertools.combinations(knobs, i)
         print 'Testing at length {}'.format(i)
 
         for row in list(jj):
             print row
-            params = []
-
-            for key in always_on:
-                params.append(key + "=on")
-
-            for key in always_off:
-                params.append(key + "=off")
-
-            for key in knobs:
-                if key in row:
-                    params.append(key + "=on")
+            params = static_params + [key + '=on' for key in row]
 
             # print {'on_params': row, 'scons_params': params}