diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2011-03-29 07:57:18 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2011-03-29 07:57:18 -0400 |
| commit | db7d7be4c385b0810378db4f5580b5dc8dcfb1ee (patch) | |
| tree | dab588924b29d7b66800d1b0560f8c3a2c584e6a /driver_garmin.c | |
| parent | 41160f7fa55bc99a3e7a57a957dcae22f33069cb (diff) | |
| download | gpsd-db7d7be4c385b0810378db4f5580b5dc8dcfb1ee.tar.gz | |
scan-build and splint cleanup. All regression tests pass.
Diffstat (limited to 'driver_garmin.c')
| -rw-r--r-- | driver_garmin.c | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/driver_garmin.c b/driver_garmin.c index 2acc8e55..f784e853 100644 --- a/driver_garmin.c +++ b/driver_garmin.c @@ -742,7 +742,7 @@ static void Build_Send_USB_Packet(struct gps_device_t *session, // So here goes just in case if (0 == (theBytesToWrite % ASYNC_DATA_SIZE)) { char *n = ""; - theBytesReturned = gpsd_write(session, n, 0); + (void)gpsd_write(session, n, 0); } } #endif /* __linux__ || S_SPLINT_S */ @@ -792,7 +792,8 @@ static void Build_Send_SER_Packet(struct gps_device_t *session, } // Add DLE, ETX *buffer++ = (uint8_t) DLE; - *buffer++ = (uint8_t) ETX; + /* we used to say n++ here, but scan-build complains */ + *buffer = (uint8_t) ETX; #if 1 gpsd_report(LOG_IO, "Garmin: SendPacket(), writing %zd bytes: %s\n", @@ -1098,7 +1099,8 @@ gps_mask_t garmin_ser_parse(struct gps_device_t *session) n + i); return 0; } - c = buf[n + i++]; + /* we used to say n++ here, but scan-build complains */ + c = buf[n + i]; if ('\x03' != c) { Send_NAK(); gpsd_report(LOG_RAW + 1, "Garmin: Final ETX not ETX\n"); |