summaryrefslogtreecommitdiff
path: root/driver_nmea0183.c
diff options
context:
space:
mode:
authorGary E. Miller <gem@rellim.com>2019-04-19 16:38:55 -0700
committerGary E. Miller <gem@rellim.com>2019-04-19 16:38:55 -0700
commit51f7435b18c134bf06f00b6234dfee0ba79d4e60 (patch)
treedcb215732096ddbd1159c7e227364e07ea672bb5 /driver_nmea0183.c
parent1b909b9b32daf8348c99e6791b657558a1af5ca5 (diff)
downloadgpsd-51f7435b18c134bf06f00b6234dfee0ba79d4e60.tar.gz
driver_nmea0183: remove redundant clears., add comment.
No need to do: session->gpsdata.satellites_visible = 0; After gpsd_zero_satellites() which does the same thing.
Diffstat (limited to 'driver_nmea0183.c')
-rw-r--r--driver_nmea0183.c6
1 files changed, 4 insertions, 2 deletions
diff --git a/driver_nmea0183.c b/driver_nmea0183.c
index b0e19582..5b0baf13 100644
--- a/driver_nmea0183.c
+++ b/driver_nmea0183.c
@@ -1270,6 +1270,10 @@ static gps_mask_t processGSV(int count, char *field[],
* second cycle (usually 10 seconds from device connect) for it to
* learn to expect BSDGV or GLGSV.
*
+ * Some GPS (Garmin 17N) spread the xxGSV over several cycles. So
+ * cycles, or cycle time, can not be used to determine start of
+ * xxGSV cycle.
+ *
* NMEA 4.1 adds a signal-ID field just before the checksum. First
* seen in May 2015 on a u-blox M8.
*/
@@ -1282,7 +1286,6 @@ static gps_mask_t processGSV(int count, char *field[],
"malformed GPGSV - fieldcount %d <= 3\n",
count);
gpsd_zero_satellites(&session->gpsdata);
- session->gpsdata.satellites_visible = 0;
return ONLINE_SET;
}
/*
@@ -1306,7 +1309,6 @@ static gps_mask_t processGSV(int count, char *field[],
gpsd_log(&session->context->errout, LOG_WARN,
"malformed GPGSV - fieldcount %d %% 4 != 0\n", count);
gpsd_zero_satellites(&session->gpsdata);
- session->gpsdata.satellites_visible = 0;
return ONLINE_SET;
}