diff options
author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
---|---|---|
committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /driver_proto.c | |
parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'driver_proto.c')
-rw-r--r-- | driver_proto.c | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/driver_proto.c b/driver_proto.c index 1b44990a..d6c61c8d 100644 --- a/driver_proto.c +++ b/driver_proto.c @@ -269,7 +269,6 @@ _proto__msg_raw(struct gps_device_t *session, unsigned char *buf, size_t data_le /** * Parse the data from the device */ -/*@ +charint @*/ gps_mask_t _proto__dispatch(struct gps_device_t *session, unsigned char *buf, size_t len) { size_t i; @@ -305,7 +304,6 @@ gps_mask_t _proto__dispatch(struct gps_device_t *session, unsigned char *buf, si return 0; } } -/*@ -charint @*/ /********************************************************** * @@ -333,7 +331,6 @@ static bool _proto__probe_detect(struct gps_device_t *session) /** * Write data to the device, doing any required padding or checksumming */ -/*@ +charint -usedef -compdef @*/ static ssize_t _proto__control_send(struct gps_device_t *session, char *msg, size_t msglen) { @@ -355,7 +352,6 @@ static ssize_t _proto__control_send(struct gps_device_t *session, "writing _proto_ control type %02x\n"); return gpsd_write(session, session->msgbuf, session->msgbuflen); } -/*@ -charint +usedef +compdef @*/ #endif /* CONTROLSEND_ENABLE */ #ifdef RECONFIGURE_ENABLE |