diff options
| author | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
|---|---|---|
| committer | Eric S. Raymond <esr@thyrsus.com> | 2015-03-30 17:10:53 -0400 |
| commit | 28bf37132d86cc59320e21d843960d086cef664c (patch) | |
| tree | bf085b5f89f1d1061b6a88ecc66c50721b13d86c /driver_rtcm3.c | |
| parent | ecb7e1ff3ec73000918c56861c55258c2d4deada (diff) | |
| download | gpsd-28bf37132d86cc59320e21d843960d086cef664c.tar.gz | |
Retire splint from our set of static analyzers.
The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches! A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.
But this has been coming for a while. Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained and somewhat
buggy and not easy to use.
Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.
All regression tests pass. PPS observed live on GR601-W.
Diffstat (limited to 'driver_rtcm3.c')
| -rw-r--r-- | driver_rtcm3.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/driver_rtcm3.c b/driver_rtcm3.c index 11bc504d..a9e05903 100644 --- a/driver_rtcm3.c +++ b/driver_rtcm3.c @@ -63,10 +63,9 @@ BSD terms apply: see the file COPYING in the distribution root for details. /* Large case statements make GNU indent very confused */ /* *INDENT-OFF* */ -/*@ -type @*//* re-enable when we're ready to take this live */ void rtcm3_unpack(const struct gps_context_t *context, - /*@out@*/ struct rtcm3_t *rtcm, char *buf) + struct rtcm3_t *rtcm, char *buf) /* break out the raw bits into the scaled report-structure fields */ { unsigned int n, n2, n3, n4; @@ -74,7 +73,6 @@ void rtcm3_unpack(const struct gps_context_t *context, unsigned int i; signed long temp; - /*@ -evalorder -sefparams -mayaliasunique @*/ #define ugrab(width) (bitcount += width, ubits((unsigned char *)buf, bitcount-width, width, false)) #define sgrab(width) (bitcount += width, sbits((signed char *)buf, bitcount-width, width, false)) #define GPS_PSEUDORANGE(fld, len) \ @@ -418,10 +416,8 @@ void rtcm3_unpack(const struct gps_context_t *context, #undef GPS_PSEUDORANGE #undef sgrab #undef ugrab - /*@ +evalorder +sefparams +mayaliasunique @*/ } /* *INDENT-ON* */ -/*@ +type @*/ #endif /* RTCM104V3_ENABLE */ |