Retire splint from our set of static analyzers.

The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches!  A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.

But this has been coming for a while.  Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained  and somewhat
buggy and not easy to use.

Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.

All regression tests pass. PPS observed live on GR601-W.

1 files changed, 7 insertions, 7 deletions

diff --git a/gpsdclient.h b/gpsdclient.h
index 2363f5a5..ba1aabfb 100644
--- a/gpsdclient.h
+++ b/gpsdclient.h
@@ -13,7 +13,7 @@ struct exportmethod_t
 /* describe an export method */
 {
     const char *name;
-    /*@null@*/const char *magic;
+    const char *magic;
     const char *description;
 };
 
@@ -23,21 +23,21 @@ struct fixsource_t
     char *spec;		/* pointer to actual storage */
     char *server;
     char *port;
-    /*@null@*/char *device;
+    char *device;
 };
 
-/*@null observer@*/struct exportmethod_t *export_lookup(const char *);
-/*@null observer@*/struct exportmethod_t *export_default(void);
+struct exportmethod_t *export_lookup(const char *);
+struct exportmethod_t *export_default(void);
 void export_list(FILE *);
 enum unit {unspecified, imperial, nautical, metric};
 enum unit gpsd_units(void);
 enum deg_str_type { deg_dd, deg_ddmm, deg_ddmmss };
 float true2magnetic(double, double, double);
 
-extern /*@observer@*/ char *deg_to_str( enum deg_str_type type,  double f);
+extern char *deg_to_str( enum deg_str_type type,  double f);
 
-extern void gpsd_source_spec(/*@null@*/const char *fromstring,
-			     /*@out@*/struct fixsource_t *source);
+extern void gpsd_source_spec(const char *fromstring,
+			     struct fixsource_t *source);
 
 char *maidenhead(double n,double e);