Change gpsd_report to no longer use a global. All regression tests pass.

This is a large, ugly change.  But without it we can't troubleshoot the
ICP/IP-source initialization bug properly - colliding definitions of
gpsd_report() were interfering with error reporting early in gpsd runs.

More cleanup work remains to be done, but at least this is working.

1 files changed, 0 insertions, 16 deletions

diff --git a/gpsdecode.c b/gpsdecode.c
index 25b1d002..90799f3d 100644
--- a/gpsdecode.c
+++ b/gpsdecode.c
@@ -27,22 +27,6 @@ static unsigned int typelist[32];
  *
  **************************************************************************/
 
-void gpsd_report(int errlevel, const char *fmt, ...)
-/* assemble command in printf(3) style, use stderr or syslog */
-{
-    if (errlevel <= verbose) {
-	char buf[BUFSIZ];
-	va_list ap;
-
-	(void)strlcpy(buf, "gpsdecode: ", BUFSIZ);
-	va_start(ap, fmt);
-	(void)vsnprintf(buf + strlen(buf), sizeof(buf) - strlen(buf), fmt,
-			ap);
-	va_end(ap);
-	(void)fputs(buf, stderr);
-    }
-}
-
 #ifdef AIVDM_ENABLE
 static void aivdm_csv_dump(struct ais_t *ais, char *buf, size_t buflen)
 {