Retire splint from our set of static analyzers.

The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches!  A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.

But this has been coming for a while.  Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained  and somewhat
buggy and not easy to use.

Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.

All regression tests pass. PPS observed live on GR601-W.

1 files changed, 0 insertions, 8 deletions

diff --git a/lcdgps.c b/lcdgps.c
index e3fa0040..b346951f 100644
--- a/lcdgps.c
+++ b/lcdgps.c
@@ -33,21 +33,17 @@
 
 #define CLIMB 3
 
-#ifndef S_SPLINT_S
 #include <netdb.h>
 #ifndef AF_UNSPEC
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <sys/socket.h>
 #endif /* AF_UNSPEC */
-#endif /* S_SPLINT_S */
 #ifndef INADDR_ANY
 #include <netinet/in.h>
 #endif /* INADDR_ANY */
-#ifndef S_SPLINT_S
 #include <arpa/inet.h>
 #include <unistd.h>
-#endif /* S_SPLINT_S */
 #include <stdlib.h>
 #include <string.h>
 #include <math.h>
@@ -259,7 +255,6 @@ int main(int argc, char *argv[])
     int n;
     for(n=0;n<CLIMB;n++) climb[n]=0.0;
 
-    /*@ -observertrans @*/
     switch (gpsd_units())
     {
     case imperial:
@@ -284,7 +279,6 @@ int main(int argc, char *argv[])
 	/* leave the default alone */
 	break;
     }
-    /*@ +observertrans @*/
 
     /* Process the options.  Print help if requested. */
     while ((option = getopt(argc, argv, "Vhl:su:")) != -1) {
@@ -309,7 +303,6 @@ int main(int argc, char *argv[])
 		continue;
 	    default:
 		(void)fprintf(stderr, "Unknown -l argument: %s\n", optarg);
-		/*@ -casebreak @*/
 	    }
 	case 's':
 	    sleep(10);
@@ -336,7 +329,6 @@ int main(int argc, char *argv[])
 		continue;
 	    default:
 		(void)fprintf(stderr, "Unknown -u argument: %s\n", optarg);
-		/*@ -casebreak @*/
 	    }
 	}
     }