Add progress messages to gpsflash. splint cleanup.

1 files changed, 3 insertions, 3 deletions

diff --git a/libgpsd_core.c b/libgpsd_core.c
index ba522ae1..3df97ead 100644
--- a/libgpsd_core.c
+++ b/libgpsd_core.c
@@ -636,16 +636,16 @@ void gpsd_zero_satellites(/*@out@*/struct gps_data_t *out)
     out->satellites = 0;
 }
 
-char *gpsd_hexdump(void *binbuf, size_t binbuflen)
+char /*@ observer @*/ *gpsd_hexdump(void *binbuf, size_t binbuflen)
 {
     static char hexbuf[MAX_PACKET_LENGTH*2+1];
     size_t i;
-    size_t len = (binbuflen > MAX_PACKET_LENGTH) ? MAX_PACKET_LENGTH : binbuflen;
+    size_t len = (size_t)((binbuflen > MAX_PACKET_LENGTH) ? MAX_PACKET_LENGTH : binbuflen);
     char *ibuf = (char *)binbuf;
     memset(hexbuf, 0, 3 * len + 1);
 
     for (i = 0; i < len; i++) {
-	(void)sprintf(hexbuf + (3 * i), "%02x", (unsigned char)ibuf[i]);
+	(void)snprintf(hexbuf + (3 * i), 4, "%02x", (unsigned int)ibuf[i]);
     }
     return hexbuf;
 }