Retire splint from our set of static analyzers.

The proximate cause was that we've been seing emission of error
messages that were randomly and disturbingly variable across different
environments - notably Raspbian and Gentoo splint gave nontrivially
different results than Ubuntu 14.10 splint. And this was *not* due to
Ubuntu patches!  A pristine splint built from the 3.1.2 tarball on
Ubuntu didn't match the Raspbian and Gentoo results either.

But this has been coming for a while.  Easy access to more modern
static analyzers such as coverity, scan-build and cppcheck has been
decreasing the utility of splint, which is unmaintained  and somewhat
buggy and not easy to use.

Only file not cleaned is ppsthread.c, because Gary has been working
on it during this cleanup.

All regression tests pass. PPS observed live on GR601-W.

1 files changed, 2 insertions, 4 deletions

diff --git a/matrix.c b/matrix.c
index 45f524e3..497946d2 100644
--- a/matrix.c
+++ b/matrix.c
@@ -8,8 +8,7 @@
 
 #include "matrix.h"
 
-/*@ -fixedformalarray -mustdefine @*/
-bool matrix_invert(double mat[4][4], /*@out@*/ double inverse[4][4])
+bool matrix_invert(double mat[4][4], double inverse[4][4])
 /* selected elements from 4x4 matrox inversion */
 {
     // Find all NECESSARY 2x2 subdeterminants
@@ -98,11 +97,10 @@ bool matrix_invert(double mat[4][4], /*@out@*/ double inverse[4][4])
 
     return true;
 }
-/*@ +fixedformalarray +mustdefine @*/
 
 #ifdef __UNUSED_
 // cppcheck-suppress unusedFunction
-void matrix_symmetrize(double mat[4][4], /*@out@*/ double prod[4][4])
+void matrix_symmetrize(double mat[4][4], double prod[4][4])
 /* symmetrize a matrix, multiply it by its transpose */
 {
     int i, j, k;