gpsd-report() -> gpsd_log()

This change is done so we can add a "log" hook to the pps_thread_t
structure (this is not done yet) and harmonize with the name of the
outer logging function. If that name had been left as gpsd_report()
there would have been scope for bad confusion with the report_hook
member.

Also, remove two stray duplicative printf calls from the NMEA2000 driver
(drivers shouldn't have printfs!) and fix one typo.

This is a step towards factoring out ntplib. For that to happen, the
PPS thread code needs to be decoupled from the core session structure.

No logic changes. Object compatibility preserved. All regression tests pass.

1 files changed, 3 insertions, 3 deletions

diff --git a/net_gnss_dispatch.c b/net_gnss_dispatch.c
index b3dfd800..a8f6fd13 100644
--- a/net_gnss_dispatch.c
+++ b/net_gnss_dispatch.c
@@ -45,9 +45,9 @@ int netgnss_uri_open(struct gps_device_t *dev, char *netgnss_service)
 #ifndef REQUIRE_DGNSS_PROTO
     return dgpsip_open(dev, netgnss_service);
 #else
-    gpsd_report(&dev->context.errout, LOG_ERROR,
-		"Unknown or unspecified DGNSS protocol for service %s\n",
-		netgnss_service);
+    gpsd_log(&dev->context.errout, LOG_ERROR,
+	     "Unknown or unspecified DGNSS protocol for service %s\n",
+	     netgnss_service);
     return -1;
 #endif
 }