summaryrefslogtreecommitdiff
path: root/repo
diff options
context:
space:
mode:
authorEric S. Raymond <esr@thyrsus.com>2010-03-26 15:59:59 -0400
committerEric S. Raymond <esr@thyrsus.com>2010-03-26 15:59:59 -0400
commitb35173545761fab41d019d49d3ca2954fc42296a (patch)
tree03080a895566fde75ec961ea7ed0c3e109c62017 /repo
parent694b3454a25eb66d8c63e9c97abf19d678d4ba80 (diff)
downloadgpsd-b35173545761fab41d019d49d3ca2954fc42296a.tar.gz
Perform bashectomy.
Diffstat (limited to 'repo')
-rwxr-xr-xrepo/hooks/ciabot.sh12
1 files changed, 6 insertions, 6 deletions
diff --git a/repo/hooks/ciabot.sh b/repo/hooks/ciabot.sh
index 6c8799fd..70c7ec26 100755
--- a/repo/hooks/ciabot.sh
+++ b/repo/hooks/ciabot.sh
@@ -4,7 +4,6 @@
# Copyright (c) 2008 Natanael Copa <natanael.copa@gmail.com>
# Copyright (c) 2010 Eric S. Raymond <esr@thyrsus.com>
#
-# Git CIA bot in bash. (no, not the POSIX shell, bash).
# Originally based on Git ciabot.pl by Petr Baudis.
# This script contains porcelain and porcelain byproducts.
#
@@ -25,9 +24,8 @@
#
#
-# The project as known to CIA. You will want to change this.
+# The project as known to CIA. You will want to change this:
#
-
project="GPSD"
#
@@ -91,9 +89,11 @@ gitver=$(git --version)
gitver=${gitver##* }
rev=$(git describe ${merged} 2>/dev/null)
-# ${merged:0:12} is the only bashism left in this script,
-# according to checkbashisms.
-[ -z ${rev} ] && rev=${merged:0:12}
+# ${merged:0:12} here was the only bashism left in the 2008 version of
+# this script, according to checkbashisms. Replace it with ${merged}
+# because it was just a fallback anyway, and it's worth taking accepting
+# a longer fallback for faster execution and removing the bash deoendency.
+[ -z ${rev} ] && rev=${merged}
rawcommit=$(git cat-file commit ${merged})
author=$(echo "$rawcommit" | sed -n -e '/^author .*<\([^@]*\).*$/s--\1-p')